postgres

Commit Graph

Author	SHA1	Message	Date
Noah Misch	dfc015dcf4	start-scripts: switch to $PGUSER before opening $PGLOG. By default, $PGUSER has permission to unlink $PGLOG. If $PGUSER replaces $PGLOG with a symbolic link, the server will corrupt the link-targeted file by appending log messages. Since these scripts open $PGLOG as root, the attack works regardless of target file ownership. "make install" does not install these scripts anywhere. Users having manually installed them in the past should repeat that process to acquire this fix. Most script users have $PGLOG writable to root only, located in $PGDATA. Just before updating one of these scripts, such users should rename $PGLOG to $PGLOG.old. The script will then recreate $PGLOG with proper ownership. Reviewed by Peter Eisentraut. Reported by Antoine Scemama. Security: CVE-2017-12172	8 years ago
Heikki Linnakangas	181bdb90ba	Fix typos in comments. Backpatch to all supported versions, where applicable, to make backpatching of future fixes go more smoothly. Josh Soref Discussion: https://www.postgresql.org/message-id/CACZqfqCf+5qRztLPgmmosr-B0Ye4srWzzw_mo4c_8_B_mtjmJQ@mail.gmail.com	9 years ago
Peter Eisentraut	05cd12ed5b	pg_ctl: Change default to wait for all actions The different actions in pg_ctl had different defaults for -w and -W, mostly for historical reasons. Most users will want the -w behavior, so make that the default. Remove the -w option in most example and test code, so avoid confusion and reduce verbosity. pg_upgrade is not touched, so it can continue to work with older installations. Reviewed-by: Beena Emerson <memissemerson@gmail.com> Reviewed-by: Ryan Murphy <ryanfmurphy@gmail.com>	9 years ago
Peter Eisentraut	e574f15d62	Updates to reflect that pg_ctl stop -m fast is the default Various example and test code used -m fast explicitly, but since it's the default, this can be omitted now or should be replaced by a better example. pg_upgrade is not touched, so it can continue to operate with older installations.	9 years ago
Peter Eisentraut	da0dbea9c3	Make whitespace consistent inside some script files I don't know what the global standard might be, but at least adjacent code should use the same whitespace.	9 years ago
Peter Eisentraut	220bb39dee	doc: Reflect renaming of Mac OS X to OS X bug #10528	11 years ago
Bruce Momjian	66d85c5356	Remove dead URL mention in OSX startup script Backpatch to 9.3. Per suggestion from Gavan Schneider	13 years ago
Tom Lane	6c8768c386	Fix overly-aggressive and inconsistent quoting in OS X start script. Sidar Lopez, per bug #6310, with some additional improvements by me. Back-patch to 9.0, where the issue was introduced.	14 years ago
Peter Eisentraut	fc946c39ae	Remove useless whitespace at end of lines	15 years ago
Tom Lane	8f5500e6bd	Make it reasonably safe to use pg_ctl to start the postmaster from a boot-time script. To do this, have pg_ctl pass down its parent shell's PID in an environment variable PG_GRANDPARENT_PID, and teach CreateLockFile() to disregard that PID as a false match if it finds it in postmaster.pid. This allows us to cope with one level of postgres-owned shell process even with pg_ctl in the way, so it's just as safe as starting the postmaster directly. You still have to be careful about how you write the initscript though. Adjust the comments in contrib/start-scripts/ to not deprecate use of pg_ctl. Also, fix the ROTATELOGS option in the OSX script, which was indulging in exactly the sort of unsafe coding that renders this fix pointless :-(. A pipe inside the "sudo" will probably result in more than one postgres-owned process hanging around.	17 years ago
Tom Lane	97e3a6e9c5	Remove inappropriate cd commands, per David Wheeler. Also make the PATH responsive to the installation prefix, which was the apparent intent of the previous edit, but not well executed.	18 years ago
Bruce Momjian	18e3992e56	Add standard error redirection for OS/X & darwin startup script. Les Hill	19 years ago
Bruce Momjian	87a9473276	Update /contrib OS/X startup files, and move to a separate OS/X directory. Mark Cotner and David Fetter	19 years ago

13 Commits (11e264517dff7a911d9e6494de86049cab42cde3)