postgres

Commit Graph

Author	SHA1	Message	Date
Tom Lane	1c72a8a37a	Fix extremely nasty little bug observed when a sub-SELECT appears in WHERE in a place where it can be part of a nestloop inner indexqual. As the code stood, it put the same physical sub-Plan node into both indxqual and indxqualorig of the IndexScan plan node. That confused later processing in the optimizer (which expected that tracing the subPlan list would visit each subplan node exactly once), and would probably have blown up in the executor if the planner hadn't choked first. Fix by making the 'fixed' indexqual be a complete deep copy of the original indexqual, rather than trying to share nodes below the topmost operator node. This had further ramifications though, because we were making the aforesaid list of sub-Plan nodes during SS_process_sublinks which is run before construction of the 'fixed' indexqual, meaning that the copy of the sub-Plan didn't show up in that list. Fix by rearranging logic so that the sub-Plan list is built by the final set_plan_references pass, not in SS_process_sublinks. This may sound like a mess, but it's actually a good deal cleaner now than it was before, because we are no longer dependent on the assumption that planning will never make a copy of a sub-Plan node.	26 years ago
Tom Lane	341b328b18	Fix a bunch of minor portability problems and maybe-bugs revealed by running gcc and HP's cc with warnings cranked way up. Signed vs unsigned comparisons, routines declared static and then defined not-static, that kind of thing. Tedious, but perhaps useful...	26 years ago
Bruce Momjian	4b2c2850bf	Clean up #include in /include directory. Add scripts for checking includes.	27 years ago
Bruce Momjian	0cf1b79528	Cleanup of /include #include's, for 6.6 only.	27 years ago
Tom Lane	fd8e580bb7	Clean up problems with sublinks + grouping in planner. Not sure if they are all fixed, because rewriter is now the stumbling block, but at least some cases work that did not work before.	27 years ago
Tom Lane	e0345e09bf	Partial fix for copied-plan bugs reported by Hiroshi Inoue: _copyResult didn't copy subPlan structure completely. _copyAgg is still busted, apparently because of changes from EXCEPT/INTERSECT patch (get_agg_tlist_references is no longer sufficient to find all aggregates). No time to look at that tonight, however.	27 years ago
Bruce Momjian	6724a50787	Change my-function-name-- to my_function_name, and optimizer renames.	27 years ago
Bruce Momjian	fa1a8d6a97	OK, folks, here is the pgindent output.	28 years ago
Bruce Momjian	a32450a585	pgindent run before 6.3 release, with Thomas' requested changes.	28 years ago
Vadim B. Mikheev	5d7923dd1c	Subselects...	28 years ago

10 Commits (1c72a8a37a446eebb09bcfb5eb6bad7ddd1655c8)