14 Commits (220db7ccd8c88aafea4629f00e8be6f9f073ed00)

Author	SHA1	Message	Date
Tom Lane	220db7ccd8	Simplify and standardize conversions between TEXT datums and ordinary C ... strings. This patch introduces four support functions cstring_to_text, cstring_to_text_with_len, text_to_cstring, and text_to_cstring_buffer, and two macros CStringGetTextDatum and TextDatumGetCString. A number of existing macros that provided variants on these themes were removed. Most of the places that need to make such conversions now require just one function or macro call, in place of the multiple notational layers that used to be needed. There are no longer any direct calls of textout or textin, and we got most of the places that were using handmade conversions via memcpy (there may be a few still lurking, though). This commit doesn't make any serious effort to eliminate transient memory leaks caused by detoasting toasted text objects before they reach text_to_cstring. We changed PG_GETARG_TEXT_P to PG_GETARG_TEXT_PP in a few places where it was easy, but much more could be done. Brendan Jurd and Tom Lane	18 years ago
Bruce Momjian	910bc51862	When text search string is too long, in error message report actual and ... maximum number of bytes allowed.	18 years ago
Bruce Momjian	9098ab9e32	Update copyrights in source tree to 2008.	18 years ago
Peter Eisentraut	f5f1355dc4	Wording improvements	18 years ago
Tom Lane	bb0e3011f8	Make a cleanup pass over error reports in tsearch code. Use ereport ... for user-facing errors, fix some poor choices of errcode, adhere to message style guide.	18 years ago
Bruce Momjian	f639df0d61	Small comment spacing improvement.	18 years ago
Bruce Momjian	7d4c99b414	Fix pgindent to properly handle 'else' and single-line comments on the ... same line; previous fix was only partial. Re-run pgindent on files that need it.	18 years ago
Tom Lane	1c92724985	Set read_only = TRUE while evaluating input queries for ts_rewrite() ... and ts_stat(), per my recent suggestion. Also add a possibly-not-needed- but-can't-hurt check for NULL SPI_tuptable, before we try to dereference same.	18 years ago
Tom Lane	bb36c51fcd	Fix several bugs in tsvectorin, including crash due to uninitialized field and ... miscomputation of required palloc size. The crash could only occur if the input contained lexemes both with and without positions, which is probably not common in practice. The miscomputation would definitely result in wasted space. Also fix some inconsistent coding around alignment of strings and positions in a tsvector value; these errors could also lead to crashes given mixed with/without position data and a machine that's picky about alignment. And be more careful about checking for overflow of string offsets. Patch is only against HEAD --- I have not looked to see if same bugs are in back-branch contrib/tsearch2 code.	18 years ago
Teodor Sigaev	57cafe7982	Refactor from Heikki Linnakangas <heikki@enterprisedb.com>: ... * Defined new struct WordEntryPosVector that holds a uint16 length and a variable size array of WordEntries. This replaces the previous convention of a variable size uint16 array, with the first element implying the length. WordEntryPosVector has the same layout in memory, but is more readable in source code. The POSDATAPTR and POSDATALEN macros are still used, though it would now be more readable to access the fields in WordEntryPosVector directly. * Removed needfree field from DocRepresentation. It was always set to false. * Miscellaneous other commenting and refactoring	18 years ago
Teodor Sigaev	978de9d06d	Improvements from Heikki Linnakangas <heikki@enterprisedb.com> ... - change the alignment requirement of lexemes in TSVector slightly. Lexeme strings were always padded to 2-byte aligned length to make sure that if there's position array (uint16[]) it has the right alignment. The patch changes that so that the padding is not done when there's no positions. That makes the storage of tsvectors without positions slightly more compact. - added some #include "miscadmin.h" lines I missed in the earlier when I added calls to check_stack_depth(). - Reimplement the send/recv functions, and added a comment above them describing the on-wire format. The CRC is now recalculated in tsquery as well per previous discussion.	18 years ago
Teodor Sigaev	e5be89981f	Refactoring by Heikki Linnakangas <heikki@enterprisedb.com> with ... small editorization by me - Brake the QueryItem struct into QueryOperator and QueryOperand. Type was really the only common field between them. QueryItem still exists, and is used in the TSQuery struct as before, but it's now a union of the two. Many other changes fell from that, like separation of pushval_asis function into pushValue, pushOperator and pushStop. - Moved some structs that were for internal use only from header files to the right .c-files. - Moved tsvector parser to a new tsvector_parser.c file. Parser code was about half of the size of tsvector.c, it's also used from tsquery.c, and it has some data structures of its own, so it seems better to separate it. Cleaned up the API so that TSVectorParserState is not accessed from outside tsvector_parser.c. - Separated enumerations (#defines, really) used for QueryItem.type field and as return codes from gettoken_query. It was just accidental code sharing. - Removed ParseQueryNode struct used internally by makepol and friends. push*-functions now construct QueryItems directly. - Changed int4 variables to just ints for variables like "i" or "array size", where the storage-size was not significant.	18 years ago
Tom Lane	79048ca1a4	Install check_stack_depth() protection in two recursive tsquery ... processing routines. Per Heikki.	18 years ago
Tom Lane	140d4ebcb4	Tsearch2 functionality migrates to core. The bulk of this work is by ... Oleg Bartunov and Teodor Sigaev, but I did a lot of editorializing, so anything that's broken is probably my fault. Documentation is nonexistent as yet, but let's land the patch so we can get some portability testing done.	18 years ago