postgres

Commit Graph

Author	SHA1	Message	Date
Tom Lane	35a3def7b2	Fix significant memory leak in contrib/xml2 functions. Most of the functions that execute XPath queries leaked the data structures created by libxml2. This memory would not be recovered until end of session, so it mounts up pretty quickly in any serious use of the feature. Per report from Pavel Stehule, though this isn't his patch. Back-patch to all supported branches.	15 years ago
Tom Lane	238e6b9519	Make contrib/xml2 use core xml.c's error handler, when available (that is, in versions >= 8.3). The core code is more robust and efficient than what was there before, and this also reduces risks involved in swapping different libxml error handler settings. Before 8.3, there is still some risk of problems if add-on modules such as Perl invoke libxml without setting their own error handler. Given the lack of reports I'm not sure there's a risk in practice, so I didn't take the step of actually duplicating the core code into older contrib/xml2 branches. Instead I just tweaked the existing code to ensure it didn't leave a dangling pointer to short-lived memory when throwing an error.	16 years ago
Tom Lane	a8ab473383	Remove xmlCleanupParser calls from contrib/xml2. These are unnecessary and probably dangerous. I don't see any immediate risk situations in the core XML support or contrib/xml2 itself, but there could be issues with external uses of libxml2, and in any case it's an accident waiting to happen.	16 years ago
Tom Lane	94152f93f5	Back-patch today's memory management fixups in contrib/xml2. Prior to 8.3, these changes are not critical for compatibility with core Postgres, since core had no libxml2 calls then. However there is still a risk if contrib/xml2 is used along with libxml2 functionality in Perl or other loadable modules. So back-patch to all versions. Also back-patch addition of regression tests. I'm not sure how many of the cases are interesting without the interaction with core xml code, but a silly regression test is still better than none at all.	16 years ago
Heikki Linnakangas	56a87f2721	Previous fix for temporary file management broke returning a set from PL/pgSQL function within an exception handler. Make sure we use the right resource owner when we create the tuplestore to hold returned tuples. Simplify tuplestore API so that the caller doesn't need to be in the right memory context when calling tuplestore_put* functions. tuplestore.c automatically switches to the memory context used when the tuplestore was created. Tuplesort was already modified like this earlier. This patch also removes the now useless MemoryContextSwitch calls from callers. Report by Aleksei on pgsql-bugs on Dec 22 2009. Backpatch to 8.1, like the previous patch that broke this.	16 years ago
Tom Lane	207f469912	Fix core dump in contrib/xml2's xpath_table() when the input query returns a NULL value. Per bug #4058.	18 years ago
Bruce Momjian	1dc3498251	Standard pgindent run for 8.1.	20 years ago
Tom Lane	be3aa30da3	Fix inadequate error checking: you can't assume that fcinfo->resultinfo is a ReturnSetInfo unless you've tested it with IsA.	21 years ago
Tom Lane	0549de06ba	Fix segfault when xpath_list function is applied to an invalid document. John Gray	21 years ago
Bruce Momjian	1646586271	Attached is a patch that adds the function xml_encode_special_chars to the xml2 contrib module. It's against 8.0beta4. It's intended for commit. Markus Bertheau <twanger@bluetwanger.de>	21 years ago
Neil Conway	04a1a24e9c	Cleanup some unnecessary void * casts when using pfree() in contrib/xml and contrib/xml2	21 years ago
Bruce Momjian	b6b71b85bc	Pgindent run for 8.0.	22 years ago
Neil Conway	bab4269b95	contrib/xml2 updates from John Gray: I have changed the name of the new parse function to xml_valid and fixed a reference to SortMem which meant that the code as supplied would work against 7.3 and 7.4 but wouldn't work in CVS.	22 years ago
Bruce Momjian	31f4b59a46	Move new version of contrib/ xml into xml2, keep old version in /xml.	22 years ago
Bruce Momjian	adca025c9e	Thanks to the generous support of Torchbox (http://www.torchbox.com ), I have been able to significantly improve the contrib/xml XPath integration code. New features: * XPath set-returning function allows multiple results from an several XPath queries to be used as a virtual table. * Using libxslt, XSLT transformations (with and without parameters) are supported. (Caution: This support allows generic URL fetching from within the backend as well). I've removed the old code so that it is all libxml based. Rather than attach as a patch, I've put the tar.gz (10k!) at http://www.azuli.co.uk/pgxml-1.0.tar.gz (all files in archive are xml/....). I think this is worth replacing the contrib version with, even though the function names have changed (though the same functionality is there), because it includes a SRF and some SPI usage, in addition to linking to an external library. And it isn't a big module! Obviously, I understand that people might prefer to move it elsewhere, or might have reservations about replacing an existing contrib module with an incompatible one. I'm open to suggestions. John Gray	22 years ago

14 Commits (35a3def7b218f2264cf34385a8487a36f96e76ec)