9 Commits (360429e1d17947c17659cd57dbaaba5c10fcbd6a)

Author	SHA1	Message	Date
Bruce Momjian	bf50caf105	pgindent run before PG 9.1 beta 1.	15 years ago
Bruce Momjian	5d950e3b0c	Stamp copyrights for year 2011.	15 years ago
Tom Lane	eb22950510	Fix PlaceHolderVar mechanism's interaction with outer joins. ... The point of a PlaceHolderVar is to allow a non-strict expression to be evaluated below an outer join, after which its value bubbles up like a Var and can be forced to NULL when the outer join's semantics require that. However, there was a serious design oversight in that, namely that we didn't ensure that there was actually a correct place in the plan tree to evaluate the placeholder :-(. It may be necessary to delay evaluation of an outer join to ensure that a placeholder that should be evaluated below the join can be evaluated there. Per recent bug report from Kirill Simonov. Back-patch to 8.4 where the PlaceHolderVar mechanism was introduced.	15 years ago
Tom Lane	c8c03d72e1	Fix another join removal bug: the check on PlaceHolderVars was wrong. ... The previous coding would decide that join removal was unsafe upon finding a PlaceHolderVar that needed to be evaluated at the inner rel and then used above the join. However, this fails to cover the case of PlaceHolderVars that refer to both the inner rel and some other rels. Per bug report from Andrus.	15 years ago
Magnus Hagander	9f2e211386	Remove cvs keywords from all files.	15 years ago
Tom Lane	4e97631e6a	Fix join-removal logic for pseudoconstant and outerjoin-delayed quals. ... In these cases a qual can get marked with the removable rel in its required_relids, but this is just to schedule its evaluation correctly, not because it really depends on the rel. We were assuming that, in effect, we could throw away *all* quals so marked, which is nonsense. Tighten up the logic to be a little more paranoid about which quals belong to the outer join being considered for removal, and arrange for all quals that don't belong to be updated so they will still get evaluated correctly. Also fix another problem that happened to be exposed by this test case, which was that make_join_rel() was failing to notice some cases where a constant-false qual could be used to prove a join relation empty. If it's a pushed-down constant false, then the relation is empty even if it's an outer join, because the qual applies after the outer join expansion. Per report from Nathan Grange. Back-patch into 9.0.	15 years ago
Bruce Momjian	239d769e7e	pgindent run for 9.0, second run	15 years ago
Tom Lane	7df4cf7fd3	Fix oversight in join removal patch: we have to delete the removed relation ... from SpecialJoinInfo relid sets as well. Per example from Vaclav Novotny.	16 years ago
Tom Lane	b78f6264eb	Rework join-removal logic as per recent discussion. In particular this ... fixes things so that it works for cases where nested removals are possible. The overhead of the optimization should be significantly less, as well.	16 years ago