Tom Lane
3b3706d2cf
Fix dblink_build_sql_insert() and related functions to handle dropped
...
columns correctly. In passing, get rid of some dead logic in the
underlying get_sql_insert() etc functions --- there is no caller that
will pass null value-arrays to them.
Per bug report from Robert Voinea.
16 years ago
Tom Lane
48a7245391
Consolidate and improve checking of key-column-attnum arguments for
...
dblink_build_sql_insert() and related functions. In particular, be sure to
reject references to dropped and out-of-range column numbers. The numbers
are still interpreted as physical column numbers, though, for backward
compatibility.
This patch replaces Joe's patch of 2010-02-03, which handled only some aspects
of the problem.
16 years ago
Bruce Momjian
8141523e35
Properly define pg_upgrade global variable, per bug report from Chris
...
Ruprecht on Mac (64 bit).
16 years ago
Tom Lane
6bbaa3148d
Rearrange dblink's dblink_build_sql_insert() and related routines to open and
...
lock the target relation just once per SQL function call. The original coding
obtained and released lock several times per call. Aside from saving a
not-insignificant number of cycles, this eliminates possible race conditions
if someone tries to modify the relation's schema concurrently. Also
centralize locking and permission-checking logic.
Problem noted while investigating a trouble report from Robert Voinea --- his
problem is still to be fixed, though.
16 years ago
Simon Riggs
ca65f2190a
Files for pg_archivecleanup
16 years ago
Simon Riggs
25fee5cfbd
New contrib module for use as an archive_cleanup_command, or as a
...
standalone utility for removing files from archive.
16 years ago
Bruce Momjian
785c2acc12
Update pg_upgrade C comment about cwd.
16 years ago
Bruce Momjian
1dc7c796c9
Have pg_upgrade create its output files in the current directory, rather
...
than in a subdirectory of the $HOME directory, or $TMP in Windows.
16 years ago
Itagaki Takahiro
5a41c317c5
Avoid "identifier will be truncated" warning in dblink
...
when connection string is longer than NAMEDATALEN.
The previous fix for long connection name broke the behavior.
16 years ago
Itagaki Takahiro
a624356072
Fix connection leak in dblink when dblink_connect() or dblink_connect_u()
...
end with "duplicate connection name" errors.
Backported to release 7.4.
16 years ago
Teodor Sigaev
3e7451a6df
Add missed function dblink_connect_u(text[,text]) to uninstall script
16 years ago
Itagaki Takahiro
7dff7260af
Fix dblink to treat connection names longer than NAMEDATALEN-2 (62 bytes).
...
Now long names are adjusted with truncate_identifier() and NOTICE messages
are raised if names are actually truncated.
Backported to release 8.0.
16 years ago
Bruce Momjian
9b6dba1193
Remove IMPLEMENTATION.jp file from pg_upgrade docs; still in pgFoundry
...
for pg_migrator, per suggestion from Magnus.
16 years ago
Bruce Momjian
02265f06b7
Update pg_upgrade IMPLEMENTATION doc file to match current 9.0 behavior.
16 years ago
Bruce Momjian
238d21d7d2
Modify pg_standby, pgbench, and pg_upgrade manual pages to be consistent
...
in their display of command-line options with other client applications.
16 years ago
Bruce Momjian
f4e9436026
Add Japanese Implementation file to CVS.
16 years ago
Bruce Momjian
7a74d70e71
Re-order pg_upgrade 'help' options to be alphabetical.
16 years ago
Bruce Momjian
6368682788
In pg_upgrade, test for datallowconn instead of hardcoding template0.
16 years ago
Bruce Momjian
00be75415c
Split apart pg_upgrade user lookup and root check so '--help' shows
...
proper default username.
16 years ago
Tom Lane
add8044778
issue_warnings() has no business freeing its parameter, especially not when
...
its sole caller does that too. Jan Matousek, via Pavel Stehule
16 years ago
Bruce Momjian
3245bd5240
Simplify pg_upgrade queries by using IN instead of multiple OR clauses
...
comparing the same column to multiple values.
16 years ago
Bruce Momjian
573e446f6f
For pg_upgrade, update template0's datfrozenxid and its relfrozenxids to
...
match the behavior of autovacuum, which does this as the xid advances
even if autovacuum is turned off.
16 years ago
Bruce Momjian
64719a18db
Use a 'datallowconn' check for avoiding 'template0', rather than
...
hardcoding a 'template0' check, per suggestion from Alvaro.
This might fix a problem where someone has allowed 'template0'
connections, but it is a cleaner approach even if doesn't fix the
bug.
16 years ago
Bruce Momjian
37953b2d20
Add pg_upgrade TESTING files explaining a testing method.
16 years ago
Bruce Momjian
5c337fb45c
Adjust pg_upgrade BSD defines for scandir(), per report from Giles Lean
16 years ago
Bruce Momjian
5781d96dc3
Change bsdi define to __bsdi__
16 years ago
Heikki Linnakangas
de4e18a34d
Fix typos in comments, spotted by Josh Kupershmidt.
16 years ago
Tom Lane
88fba7089e
Fix another obvious bug pointed out by a compiler warning.
16 years ago
Tom Lane
0546906064
Remove another unsafe use of random data as a format string.
16 years ago
Tom Lane
8eac39780d
Get rid of unsafe sprintf and snprintf usages. Per compiler warnings.
16 years ago
Tom Lane
adf6b8edfb
Spell __darwin__ correctly, to suppress compiler warning on OSX.
16 years ago
Bruce Momjian
e9ad14f9f4
Use NAMEDATALEN instead of local define.
...
Modify path separators for Win32.
Per ideas from Takahiro Itagaki
16 years ago
Bruce Momjian
36d3afd2d4
Remove all mentions of EnterpriseDB Advanced Server from pg_upgrade;
...
EDB must maintain their own patch set for this.
16 years ago
Tom Lane
382ff21203
Fix up lame idea of not using autoconf to determine if platform has scandir().
...
Should fix buildfarm failures.
16 years ago
Magnus Hagander
2b61b3e507
Assorted fixes to make pg_upgrade build on MSVC.
...
* There is no chmod() on Windows.
* Must always use the 3-parameter version of open()
* There is no dynloader.h - but it also appears unnecessary on all platforms
* Don't include shlobj.h because it causes compile errors, and from what I can
see it's not actually used. This may need to be added back for mingw
and/or cygwin in the worst case.
16 years ago
Tom Lane
c2e7f78abe
Fix wrong subdir. Per buildfarm.
16 years ago
Bruce Momjian
9885206cab
Move pg_upgrade shared library out into its own /contrib directory
...
(pg_upgrade_support).
16 years ago
Tom Lane
44e55690fd
Hook pg_upgrade into the contrib makefile structure so it gets built
...
on the buildfarm.
16 years ago
Tom Lane
c9c25a982c
Clean up unnecessary unportability and compiler warnings by removing the
...
cmp parameter for pg_scandir(). The code failed to support this anyway
for Sun/Windows, so pretending we could accept a parameter other than
NULL was just asking for trouble.
16 years ago
Bruce Momjian
b460b5cd11
Move pg_upgrade TODO to TODO wiki.
16 years ago
Bruce Momjian
395d1259ad
Add PGFILEDESC description to Makefiles for all /contrib executables.
...
Add PGAPPICON to all executable makefiles.
16 years ago
Bruce Momjian
561afa534d
Small formatting adjustment.
16 years ago
Bruce Momjian
a898199df5
Add pg_upgrade IMPLEMENTATION file to CVS.
16 years ago
Bruce Momjian
6c4a98d99c
Add TODO file to CVS.
16 years ago
Bruce Momjian
c2e9b2f288
Add pg_upgrade to /contrib; will be in 9.0 beta2.
...
Add documentation.
Supports migration from PG 8.3 and 8.4.
16 years ago
Tom Lane
77acab75df
Modify ShmemInitStruct and ShmemInitHash to throw errors internally,
...
rather than returning NULL for some-but-not-all failures as they used to.
Remove now-redundant tests for NULL from call sites.
We had to do something about this because many call sites were failing to
check for NULL; and changing it like this seems a lot more useful and
mistake-proof than adding checks to the call sites without them.
16 years ago
Tom Lane
a2de4826e9
Fix contrib/tsearch2 expected results to match recent changes in URL parsing.
16 years ago
Robert Haas
33980a0640
Fix various instances of "the the".
...
Two of these were pointed out by Erik Rijkers; the rest I found.
16 years ago
Andrew Dunstan
ce36151ac7
Make dmetaphone.c safe for pgindent and fussy compilers. Still to do: make it properly encoding aware w.r.t. chars U+00C7 and U+00D1.
16 years ago
Tom Lane
33065ef8bc
Ensure that contrib/pgstattuple functions respond to cancel interrupts
...
reasonably promptly, by adding CHECK_FOR_INTERRUPTS in the per-page loops.
Tatsuhito Kasahara
16 years ago