postgres

Commit Graph

Author	SHA1	Message	Date
Tom Lane	ccd3623256	Ensure Soundex difference() function handles empty input sanely. fuzzystrmatch's difference() function assumes that _soundex() always initializes its output buffer fully. This was not so for the case of a string containing no alphabetic characters, resulting in unstable output and Valgrind complaints. Fix by using memset() to fill the whole buffer in the early-exit case. Also make some cosmetic improvements (I didn't care for the random switches between "instr[0]" and "*instr" notation). Report and diagnosis by Alexander Lakhin (bug #17935). Back-patch to all supported branches. Discussion: https://postgr.es/m/17935-b99316aa79c18513@postgresql.org	3 years ago
Peter Eisentraut	6141123a82	fuzzystrmatch: Add test suite Reviewed-by: David Steele <david@pgmasters.net>	8 years ago

Author

SHA1

Message

Date

Tom Lane

ccd3623256

Ensure Soundex difference() function handles empty input sanely.

fuzzystrmatch's difference() function assumes that _soundex()
always initializes its output buffer fully.  This was not so for
the case of a string containing no alphabetic characters, resulting
in unstable output and Valgrind complaints.

Fix by using memset() to fill the whole buffer in the early-exit
case.  Also make some cosmetic improvements (I didn't care for the
random switches between "instr[0]" and "*instr" notation).

Report and diagnosis by Alexander Lakhin (bug #17935).
Back-patch to all supported branches.

Discussion: https://postgr.es/m/17935-b99316aa79c18513@postgresql.org

3 years ago

Peter Eisentraut

6141123a82

fuzzystrmatch: Add test suite

Reviewed-by: David Steele <david@pgmasters.net>

8 years ago

2 Commits (3dadeef5d9ffe94deac926d7266a2ec64795e159)