5 Commits (44475e782f4674d257b9e5c1a3930218a4b4deea)

Author	SHA1	Message	Date
Peter Eisentraut	cfe380a6dd	Augment test coverage in PL/Python, especially for error conditions.	17 years ago
Peter Eisentraut	9d9848668f	Split the plpython regression test into test cases arranged by topic, instead ... of the previous monolithic setup-create-run sequence, that was apparently inherited from a previous test infrastructure, but makes working with the tests and adding new ones weird.	17 years ago
Bruce Momjian	819f22a302	Allow PL/python to return composite types and result sets ... Sven Suursoho	20 years ago
Bruce Momjian	37f11c3081	This patch addresses the problem mentioned in the "process crash ... when a plpython function returns unicode" thread: http://archives.postgresql.org/pgsql-bugs/2005-06/msg00105.php In several places PL/Python was calling PyObject_Str() and then PyString_AsString() without checking if the former had returned NULL to indicate an error. PyString_AsString() doesn't expect a NULL argument, so passing one causes a segmentation fault. This patch adds checks for NULL and raises errors via PLy_elog(), which prints details of the underlying Python exception. The patch also adds regression tests for these checks. All tests pass on my Solaris 9 box running HEAD and Python 2.4.1. In one place the patch doesn't call PLy_elog() because that could cause infinite recursion; see the comment I added. I'm not sure how to test that particular case or whether it's even possible to get an error there: the value that the code should check is the Python exception type, so I wonder if a NULL value "shouldn't happen." This patch converts NULL to "Unknown Exception" but I wonder if an Assert() would be appropriate. The patch is against HEAD but the same changes should be applied to earlier versions because they have the same problem. The patch might not apply cleanly against earlier versions -- will the committer take care of little differences or should I submit different versions of the patch? Michael Fuhr	21 years ago
Tom Lane	0ff7a2c2ad	Convert the existing regression test scripts for the various optional ... PLs to use the standard pg_regress infrastructure. No changes in the tests themselves. Andrew Dunstan	21 years ago