68 Commits (4d3f03f42227bb351c2021a9ccea2fff9c023cfc)

Author	SHA1	Message	Date
Peter Eisentraut	233bfe0673	Fix PQconninfoParse error message handling ... The returned error message already includes a newline, but the callers were adding their own when printing it out.	13 years ago
Stephen Frost	d368a301b3	pg_receivexlog - Exit on failure to parse ... In streamutil.c:GetConnection(), upgrade failure to parse the connection string to an exit(1) instead of simply returning NULL. Most callers already immediately exited, but pg_receivexlog would loop on this case, continually trying to re-parse the connection string (which can't be changed after pg_receivexlog has started). GetConnection() was already expected to exit(1) in some cases (eg: failure to allocate memory or if unable to determine the integer_datetimes flag), so this change shouldn't surprise anyone. Began looking at this due to the Coverity scanner complaining that we were leaking err_msg in this case- no longer an issue since we just exit(1) immediately.	13 years ago
Bruce Momjian	9af4159fce	pgindent run for release 9.3 ... This is the first run of the Perl-based pgindent script. Also update pgindent instructions.	13 years ago
Heikki Linnakangas	aa05c37e82	Add -d option to pg_basebackup and pg_receivexlog, for connection string. ... Without this, there's no way to pass arbitrary libpq connection parameters to these applications. It's a bit strange that the option is called -d/--dbname, when in fact you can *not* pass a database name in it, but it's consistent with other client applications where a connection string is also passed using -d. Original patch by Amit Kapila, heavily modified by me.	13 years ago
Alvaro Herrera	8396447cdb	Create libpgcommon, and move pg_malloc et al to it ... libpgcommon is a new static library to allow sharing code among the various frontend programs and backend; this lets us eliminate duplicate implementations of common routines. We avoid libpgport, because that's intended as a place for porting issues; per discussion, it seems better to keep them separate. The first use case, and the only implemented by this patch, is pg_malloc and friends, which many frontend programs were already using. At the same time, we can use this to provide palloc emulation functions for the frontend; this way, some palloc-using files in the backend can also be used by the frontend cleanly. To do this, we change palloc() in the backend to be a function instead of a macro on top of MemoryContextAlloc(). This was previously believed to cause loss of performance, but this implementation has been tweaked by Tom and Andres so that on modern compilers it provides a slight improvement over the previous one. This lets us clean up some places that were already with localized hacks. Most of the pg_malloc/palloc changes in this patch were authored by Andres Freund. Zoltán Böszörményi also independently provided a form of that. libpgcommon infrastructure was authored by Álvaro.	13 years ago
Bruce Momjian	bd61a623ac	Update copyrights for 2013 ... Fully update git head, and update back branches in ./COPYRIGHT and legal.sgml files.	13 years ago
Heikki Linnakangas	527668717a	Make xlog_internal.h includable in frontend context. ... This makes unnecessary the ugly hack used to #include postgres.h in pg_basebackup. Based on Alvaro Herrera's patch	13 years ago
Tom Lane	09ac603c36	Work around unportable behavior of malloc(0) and realloc(NULL, 0). ... On some platforms these functions return NULL, rather than the more common practice of returning a pointer to a zero-sized block of memory. Hack our various wrapper functions to hide the difference by substituting a size request of 1. This is probably not so important for the callers, who should never touch the block anyway if they asked for size 0 --- but it's important for the wrapper functions themselves, which mistakenly treated the NULL result as an out-of-memory failure. This broke at least pg_dump for the case of no user-defined aggregates, as per report from Matthew Carrington. Back-patch to 9.2 to fix the pg_dump issue. Given the lack of previous complaints, it seems likely that there is no live bug in previous releases, even though some of these functions were in place before that.	13 years ago
Tom Lane	a563d94180	Standardize naming of malloc/realloc/strdup wrapper functions. ... We had a number of variants on the theme of "malloc or die", with the majority named like "pg_malloc", but by no means all. Standardize on the names pg_malloc, pg_malloc0, pg_realloc, pg_strdup. Get rid of pg_calloc entirely in favor of using pg_malloc0. This is an essentially cosmetic change, so no back-patch. (I did find a couple of places where psql and pg_dump were using plain malloc or strdup instead of the pg_ versions, but they don't look significant enough to bother back-patching.)	13 years ago
Alvaro Herrera	2f29f011c8	pg_basebackup: stylistic adjustments ... The most user-visible part of this is to change the long options --statusint and --noloop to --status-interval and --no-loop, respectively, per discussion. Also, consistently enclose file names in double quotes, per our conventions; and consistently use the term "transaction log file" to talk about WAL segments. (Someday we may need to go over this terminology and make it consistent across the whole source code.) Finally, reflow the code to better fit in 80 columns, and have pgindent fix it up some more.	14 years ago
Magnus Hagander	058a050ec7	Fix memory and file descriptor leaks in pg_receivexlog/pg_basebackup ... When the internal loop mode was added, freeing memory and closing filedescriptors before returning became important, and a few cases in the code missed that. Fujii Masao	14 years ago
Peter Eisentraut	2b44306315	Assorted message style improvements	14 years ago
Bruce Momjian	927d61eeff	Run pgindent on 9.2 source tree in preparation for first 9.3 ... commit-fest.	14 years ago
Magnus Hagander	16282ae688	Make pg_recievexlog by default loop on connection failures ... Avoids the need for an external script in the most common scenario. Behavior can be overridden using the -n/--noloop commandline parameter.	14 years ago
Magnus Hagander	77f93cb32d	Add missing PQfinish() calls ... Fujii Masao	14 years ago
Robert Haas	304aa339b2	Prevent pg_basebackup when integer_datetimes flag doesn't match. ... Magnus Hagander, reviewed by Fujii Masao, with slight wording changes by me.	14 years ago
Bruce Momjian	e126958c2e	Update copyright notices for year 2012.	14 years ago
Magnus Hagander	d9bae53173	Implement streaming xlog for backup tools ... Add option for parallel streaming of the transaction log while a base backup is running, to get the logfiles before the server has removed them. Also add a tool called pg_receivexlog, which streams the transaction log into files, creating a log archive without having to wait for segments to complete, thus decreasing the window of data loss without having to waste space using archive_timeout. This works best in combination with archive_command - suggested usage docs etc coming later.	14 years ago