317 Commits (4f622503d6de975ac87448aea5cea7de4bc140d5)

Author	SHA1	Message	Date
Tom Lane	f905d65ee3	Rewrite of planner statistics-gathering code. ANALYZE is now available as ... a separate statement (though it can still be invoked as part of VACUUM, too). pg_statistic redesigned to be more flexible about what statistics are stored. ANALYZE now collects a list of several of the most common values, not just one, plus a histogram (not just the min and max values). Random sampling is used to make the process reasonably fast even on very large tables. The number of values and histogram bins collected is now user-settable via an ALTER TABLE command. There is more still to do; the new stats are not being used everywhere they could be in the planner. But the remaining changes for this project should be localized, and the behavior is already better than before. A not-very-related change is that sorting now makes use of btree comparison routines if it can find one, rather than invoking '<' twice.	25 years ago
Bruce Momjian	0686d49da0	Remove dashes in comments that don't need them, rewrap with pgindent.	25 years ago
Bruce Momjian	9e1552607a	pgindent run. Make it all clean.	25 years ago
Tom Lane	13cc7eb3e2	Clean up two rather nasty bugs in operator selection code. ... 1. If there is exactly one pg_operator entry of the right name and oprkind, oper() and related routines would return that entry whether its input type had anything to do with the request or not. This is just premature optimization: we shouldn't return the single candidate until after we verify that it really is a valid candidate, ie, is at least coercion-compatible with the given types. 2. oper() and related routines only promise a coercion-compatible result. Unfortunately, there were quite a few callers that assumed the returned operator is binary-compatible with the given datatype; they would proceed to call it without making any datatype coercions. These callers include sorting, grouping, aggregation, and VACUUM ANALYZE. In general I think it is appropriate for these callers to require an exact or binary-compatible match, so I've added a new routine compatible_oper() that only succeeds if it can find an operator that doesn't require any run-time conversions. Callers now call oper() or compatible_oper() depending on whether they are prepared to deal with type conversion or not. The upshot of these bugs is revealed by the following silliness in PL/Tcl's selftest: it creates an operator @< on int4, and then tries to use it to sort a char(N) column. The system would let it do that :-( (and evidently has done so since 6.3 :-( :-(). The result in this case was just a silly sort order, but the reverse combination would've provoked coredump from trying to dereference integers. With this fix you get more reasonable behavior: pltcl_test=# select * from T_pkey1 order by key1, key2 using @<; ERROR: Unable to identify an operator '@<' for types 'bpchar' and 'bpchar' You will have to retype this query using an explicit cast	25 years ago
Bruce Momjian	623bf843d2	Change Copyright from PostgreSQL, Inc to PostgreSQL Global Development Group.	25 years ago
Tom Lane	786f1a59cd	Fix all the places that called heap_update() and heap_delete() without ... bothering to check the return value --- which meant that in case the update or delete failed because of a concurrent update, you'd not find out about it, except by observing later that the transaction produced the wrong outcome. There are now subroutines simple_heap_update and simple_heap_delete that should be used anyplace that you're not prepared to do the full nine yards of coping with concurrent updates. In practice, that seems to mean absolutely everywhere but the executor, because *noplace* else was checking.	25 years ago
Tom Lane	36839c1927	Restructure backend SIGINT/SIGTERM handling so that 'die' interrupts ... are treated more like 'cancel' interrupts: the signal handler sets a flag that is examined at well-defined spots, rather than trying to cope with an interrupt that might happen anywhere. See pghackers discussion of 1/12/01.	25 years ago
Tom Lane	77698e11a9	Avoid repeated detoasting (and possible memory leaks) when processing ... a toasted datum in VACUUM ANALYZE.	25 years ago
Tom Lane	a933ee38bb	Change SearchSysCache coding conventions so that a reference count is ... maintained for each cache entry. A cache entry will not be freed until the matching ReleaseSysCache call has been executed. This eliminates worries about cache entries getting dropped while still in use. See my posting to pg-hackers of even date for more info.	25 years ago
Bruce Momjian	85f1950a6f	Remove NO_SECURITY define.	25 years ago
Bruce Momjian	b32685a999	Add proofreader's changes to docs. ... Fix misspelling of disbursion to dispersion.	25 years ago
Peter Eisentraut	6dc249610a	Code cleanup of user name and user id handling in the backend. The current ... user is now defined in terms of the user id, the user name is only computed upon request (for display purposes). This is kind of the opposite of the previous state, which would maintain the user name and compute the user id for permission checks. Besides perhaps saving a few cycles (integer vs string), this now creates a single point of attack for changing the user id during a connection, for purposes of "setuid" functions, etc.	25 years ago
Tom Lane	e67ff6b670	fmgr interface mopup work. Use new DatumGetBool and BoolGetDatum ... macros where appropriate (the code used to have several different ways of doing that, including Int32, Int8, UInt8, ...). Remove last few references to float32 and float64 typedefs --- it's all float4/float8 now. The typedefs themselves should probably stay in c.h for a release or two, though, to avoid breaking user-written C functions.	25 years ago
Tom Lane	c3e2a951b4	Toast all the system-table columns that seem to need it. It turns out ... that giving pg_proc a toast table required solving the same problems we'd have to solve for pg_class --- pg_proc is one of the relations that gets bootstrapped in relcache.c. Solution is to go back at the end of initialization and read in the *real* pg_class row to replace the phony entry created by formrdesc(). This should work as long as there's no need to touch any toasted values during initialization, which seems a reasonable assumption. Although I did not add a toast-table for every single system table with a varlena attribute, I believe that it would work to just do ALTER TABLE pg_class CREATE TOAST TABLE. So anyone who's really intent on having several thousand ACL entries for a rel could do it. NOTE: I didn't force initdb, but you must do one to see the effects of this patch.	25 years ago
Tom Lane	40f64064ff	Update textin() and textout() to new fmgr style. This is just phase ... one of updating the whole text datatype, but there are so dang many calls of these two routines that it seems worth a separate commit.	26 years ago
Tom Lane	0f1e39643d	Third round of fmgr updates: eliminate calls using fmgr() and ... fmgr_faddr() in favor of new-style calls. Lots of cleanup of sloppy casts to use XXXGetDatum and DatumGetXXX ...	26 years ago
Bruce Momjian	f089c36419	Add analyze.c file for split.	26 years ago