15 Commits (5223f96d92fd6fb6fcf260da9f9cb111831f0b37)

Author	SHA1	Message	Date
Tom Lane	225f0aa3df	Prevent inlining a SQL function with multiple OUT parameters. ... There were corner cases in which the planner would attempt to inline such a function, which would result in a failure at runtime due to loss of information about exactly what the result record type is. Fix by disabling inlining when the function's recorded result type is RECORD. There might be some sub-cases where inlining could still be allowed, but this is a simple and backpatchable fix, so leave refinements for another day. Per bug #5777 from Nate Carson. Back-patch to all supported branches. 8.1 happens to avoid a core-dump here, but it still does the wrong thing.	15 years ago
Tom Lane	53e757689c	Make NestLoop plan nodes pass outer-relation variables into their inner ... relation using the general PARAM_EXEC executor parameter mechanism, rather than the ad-hoc kluge of passing the outer tuple down through ExecReScan. The previous method was hard to understand and could never be extended to handle parameters coming from multiple join levels. This patch doesn't change the set of possible plans nor have any significant performance effect, but it's necessary infrastructure for future generalization of the concept of an inner indexscan plan. ExecReScan's second parameter is now unused, so it's removed.	16 years ago
Tom Lane	a620d5005d	Fix a bug introduced when set-returning SQL functions were made inline-able: ... we have to cope with the possibility that the declared result rowtype contains dropped columns. This fails in 8.4, as per bug #5240. While at it, be more paranoid about inserting binary coercions when inlining. The pre-8.4 code did not really need to worry about that because it could not inline at all in any case where an added coercion could change the behavior of the function's statement. However, when inlining a SRF we allow sorting, grouping, and set-ops such as UNION. In these cases, modifying one of the targetlist entries that the sort/group/setop depends on could conceivably change the behavior of the function's statement --- so don't inline when such a case applies.	16 years ago
Tom Lane	717fa274d1	Support use of function argument names to identify which actual arguments ... match which function parameters. The syntax uses AS, for example funcname(value AS arg1, anothervalue AS arg2) Pavel Stehule	16 years ago
Tom Lane	0c19f05803	Fix things so that you can still do "select foo()" where foo is a SQL ... function returning setof record. This used to work, more or less accidentally, but I had broken it while extending the code to allow materialize-mode functions to be called in select lists. Add a regression test case so it doesn't get broken again. Per gripe from Greg Davidson.	17 years ago
Tom Lane	793d5662e8	Fix an oversight in the support for storing/retrieving "minimal tuples" in ... TupleTableSlots. We have functions for retrieving a minimal tuple from a slot after storing a regular tuple in it, or vice versa; but these were implemented by converting the internal storage from one format to the other. The problem with that is it invalidates any pass-by-reference Datums that were already fetched from the slot, since they'll be pointing into the just-freed version of the tuple. The known problem cases involve fetching both a whole-row variable and a pass-by-reference value from a slot that is fed from a tuplestore or tuplesort object. The added regression tests illustrate some simple cases, but there may be other failure scenarios traceable to the same bug. Note that the added tests probably only fail on unpatched code if it's built with --enable-cassert; otherwise the bug leads to fetching from freed memory, which will not have been overwritten without additional conditions. Fix by allowing a slot to contain both formats simultaneously; which turns out not to complicate the logic much at all, if anything it seems less contorted than before. Back-patch to 8.2, where minimal tuples were introduced.	17 years ago
Tom Lane	9b46abb7c4	Allow SQL-language functions to return the output of an INSERT/UPDATE/DELETE ... RETURNING clause, not just a SELECT as formerly. A side effect of this patch is that when a set-returning SQL function is used in a FROM clause, performance is improved because the output is collected into a tuplestore within the function, rather than using the less efficient value-per-call mechanism.	17 years ago
Tom Lane	69a785b8bf	Implement SQL-spec RETURNS TABLE syntax for functions. ... (Unlike the original submission, this patch treats TABLE output parameters as being entirely equivalent to OUT parameters -- tgl) Pavel Stehule	18 years ago
Peter Eisentraut	7f4f42fa10	Clean up CREATE FUNCTION syntax usage in contrib and elsewhere, in ... particular get rid of single quotes around language names and old WITH () construct.	20 years ago
Tom Lane	47888fe842	First phase of OUT-parameters project. We can now define and use SQL ... functions with OUT parameters. The various PLs still need work, as does pg_dump. Rudimentary docs and regression tests included.	21 years ago
Bruce Momjian	38fb906f93	> Joe Conway <mail@joeconway.com> writes: ... >>ISTM that "source" is worth knowing. > > Hm, possibly. Any other opinions? This version has the seven fields I proposed, including "source". Here's an example that shows why I think it's valuable: regression=# \x Expanded display is on. regression=# select * from pg_settings where name = 'enable_seqscan'; -[ RECORD 1 ]----------- name | enable_seqscan setting | on context | user vartype | bool source | default min_val | max_val | regression=# update pg_settings set setting = 'off' where name = 'enable_seqscan'; -[ RECORD 1 ]--- set_config | off regression=# select * from pg_settings where name = 'enable_seqscan'; -[ RECORD 1 ]----------- name | enable_seqscan setting | off context | user vartype | bool source | session min_val | max_val | regression=# alter user postgres set enable_seqscan to 'off'; ALTER USER (log out and then back in again) regression=# \x Expanded display is on. regression=# select * from pg_settings where name = 'enable_seqscan'; -[ RECORD 1 ]----------- name | enable_seqscan setting | off context | user vartype | bool source | user min_val | max_val | In the first case, enable_seqscan is set to its default value. After setting it to off, it is obvious that the value has been changed for the session only. In the third case, you can see that the value has been set specifically for the user. Joe Conway	23 years ago
Tom Lane	549928d99b	Fix for breakage of C-coded SRFs, from Joe Conway.	24 years ago
Tom Lane	64505ed58b	Code review for standalone composite types, query-specified composite ... types, SRFs. Not happy with memory management yet, but I'll commit these other changes.	24 years ago
Tom Lane	30ec31604d	Add code to extract dependencies from an expression tree, and use it ... to build dependencies for rules, constraint expressions, and default expressions. Repair some problems in the original design of recursiveDeletion() exposed by more complex dependency sets. Fix regression tests that were deleting things in illegal sequences.	24 years ago
Bruce Momjian	95712b15b1	Add missing regression files for SRF.	24 years ago