16 Commits (815f58407cdd06c39fdbb052a33b61d3e605e7ae)

Author	SHA1	Message	Date
Teodor Sigaev	10dd8df68e	Reduce size of critical section and remove call of user-defined functions in ... insertion and deletion, modify gistSplit() to do not use buffers. TODO: gistvacuumcleanup and XLOG	19 years ago
Tom Lane	c9a2b6d4ca	Fix thinko in gistRedoPageUpdateRecord: if XLR_BKP_BLOCK_1 is set, we ... don't have anything to do to the page, but we still have to adjust the incomplete_inserts list that we're maintaining in memory.	20 years ago
Tom Lane	a8b8f4db23	Clean up WAL/buffer interactions as per my recent proposal. Get rid of the ... misleadingly-named WriteBuffer routine, and instead require routines that change buffer pages to call MarkBufferDirty (which does exactly what it says). We also require that they do so before calling XLogInsert; this takes care of the synchronization requirement documented in SyncOneBuffer. Note that because bufmgr takes the buffer content lock (in shared mode) while writing out any buffer, it doesn't matter whether MarkBufferDirty is executed before the buffer content change is complete, so long as the content change is completed before releasing exclusive lock on the buffer. So it's OK to set the dirtybit before we fill in the LSN. This eliminates the former kluge of needing to set the dirtybit in LockBuffer. Aside from making the code more transparent, we can also add some new debugging assertions, in particular that the caller of MarkBufferDirty must hold the buffer content lock, not merely a pin.	20 years ago
Tom Lane	89395bfa6f	Improve gist XLOG code to follow the coding rules needed to prevent ... torn-page problems. This introduces some issues of its own, mainly that there are now some critical sections of unreasonably broad scope, but it's a step forward anyway. Further cleanup will require some code refactoring that I'd prefer to get Oleg and Teodor involved in.	20 years ago
Tom Lane	6d61cdec07	Clean up and document the API for XLogOpenRelation and XLogReadBuffer. ... This commit doesn't make much functional change, but it does eliminate some duplicated code --- for instance, PageIsNew tests are now done inside XLogReadBuffer rather than by each caller. The GIST xlog code still needs a lot of love, but I'll worry about that separately.	20 years ago
Tom Lane	0a20207060	Arrange to emit a description of the current XLOG record as error context ... when an error occurs during xlog replay. Also, replace the former risky 'write into a fixed-size buffer with no overflow detection' API for XLOG record description routines; use an expansible StringInfo instead. (The latter accounts for most of the patch bulk.) Qingqing Zhou	20 years ago
Bruce Momjian	f2f5b05655	Update copyright for 2006. Update scripts.	20 years ago
Bruce Momjian	b3364fc81b	pgindent new GIST index code, per request from Tom.	20 years ago
Tom Lane	08817bdb76	Adjust GiST error messages to conform to message style guidelines.	20 years ago
Teodor Sigaev	5350216156	Improve error messages and add comment	20 years ago
Teodor Sigaev	898a7bd13b	Bug fixes for GiST crash recovery. ... - add forgotten check of lsn for insert completion - remove level of pages: hard to check in recovery - some cleanups	20 years ago
Teodor Sigaev	88b49cdc95	Code cleanup. gistfillbuffer accepts InvalidOffsetNumber.	20 years ago
Teodor Sigaev	e8cab5fe49	Concurrency for GiST ... - full concurrency for insert/update/select/vacuum: - select and vacuum never locks more than one page simultaneously - select (gettuple) hasn't any lock across it's calls - insert never locks more than two page simultaneously: - during search of leaf to insert it locks only one page simultaneously - while walk upward to the root it locked only parent (may be non-direct parent) and child. One of them X-lock, another may be S- or X-lock - 'vacuum full' locks index - improve gistgetmulti - simplify XLOG records Fix bug in index_beginscan_internal: LockRelation may clean rd_aminfo structure, so move GET_REL_PROCEDURE after LockRelation	20 years ago
Teodor Sigaev	1bfdd1a893	fix founded hole in recovery after crash, add vacuum_delay_point()	20 years ago
Teodor Sigaev	d544ec8bbd	1. full functional WAL for GiST ... 2. improve vacuum for gist - use FSM - full vacuum: - reforms parent tuple if it's needed ( tuples was deleted on child page or parent tuple remains invalid after crash recovery ) - truncate index file if possible 3. fixes bugs and mistakes	20 years ago
Teodor Sigaev	37c839365c	WAL for GiST. It work for online backup and so on, but on ... recovery after crash (power loss etc) it may say that it can't restore index and index should be reindexed. Some refactoring code.	20 years ago