8 Commits (a7d9203cc4edfbcc283732efea6d54db0399ccee)

Author	SHA1	Message	Date
Bruce Momjian	6416a82a62	Remove unnecessary #include references, per pgrminclude script.	14 years ago
Alvaro Herrera	6f3efa76b0	Remove rel.h from objectaddress.h; only relcache.h is necessary. ... Add rel.h to some files that now need it.	14 years ago
Bruce Momjian	bf50caf105	pgindent run before PG 9.1 beta 1.	14 years ago
Tom Lane	6e197cb2e5	Improve reporting of run-time-detected indeterminate-collation errors. ... pg_newlocale_from_collation does not have enough context to give an error message that's even a little bit useful, so move the responsibility for complaining up to its callers. Also, reword ERRCODE_INDETERMINATE_COLLATION error messages in a less jargony, more message-style-guide-compliant fashion.	14 years ago
Tom Lane	e3c732a85c	Create an explicit concept of collations that work for any encoding. ... Use collencoding = -1 to represent such a collation in pg_collation. We need this to make the "default" entry work sanely, and a later patch will fix the C/POSIX entries to be represented this way instead of duplicating them across all encodings. All lookup operations now search first for an entry that's database-encoding-specific, and then for the same name with collencoding = -1. Also some incidental code cleanup in collationcmds.c and pg_collation.c.	15 years ago
Tom Lane	a051ef699c	Remove collation information from TypeName, where it does not belong. ... The initial collations patch treated a COLLATE spec as part of a TypeName, following what can only be described as brain fade on the part of the SQL committee. It's a lot more reasonable to treat COLLATE as a syntactically separate object, so that it can be added in only the productions where it actually belongs, rather than needing to reject it in a boatload of places where it doesn't belong (something the original patch mostly failed to do). In addition this change lets us meet the spec's requirement to allow COLLATE anywhere in the clauses of a ColumnDef, and it avoids unfriendly behavior for constructs such as "foo::type COLLATE collation". To do this, pull collation information out of TypeName and put it in ColumnDef instead, thus reverting most of the collation-related changes in parse_type.c's API. I made one additional structural change, which was to use a ColumnDef as an intermediate node in AT_AlterColumnType AlterTableCmd nodes. This provides enough room to get rid of the "transform" wart in AlterTableCmd too, since the ColumnDef can carry the USING expression easily enough. Also fix some other minor bugs that have crept in in the same areas, like failure to copy recently-added fields of ColumnDef in copyfuncs.c. While at it, document the formerly secret ability to specify a collation in ALTER TABLE ALTER COLUMN TYPE, ALTER TYPE ADD ATTRIBUTE, and ALTER TYPE ALTER ATTRIBUTE TYPE; and correct some misstatements about what the default collation selection will be when COLLATE is omitted. BTW, the three-parameter form of format_type() should go away too, since it just contributes to the confusion in this area; but I'll do that in a separate patch.	15 years ago
Peter Eisentraut	4442e1975d	When creating a collation, check that the locales can be loaded ... This is the same check that would happen later when the collation is used, but it's friendlier to check the collation already when it is created.	15 years ago
Peter Eisentraut	b313bca0af	DDL support for collations ... - collowner field - CREATE COLLATION - ALTER COLLATION - DROP COLLATION - COMMENT ON COLLATION - integration with extensions - pg_dump support for the above - dependency management - psql tab completion - psql \dO command	15 years ago