14 Commits (a98871b7ac601b4ebe6ba050b1f9cbfdd5d71ded)

Author	SHA1	Message	Date
Tom Lane	a98871b7ac	Tweak indexscan machinery to avoid taking an AccessShareLock on an index ... if we already have a stronger lock due to the index's table being the update target table of the query. Same optimization I applied earlier at the table level. There doesn't seem to be much interest in the more radical idea of not locking indexes at all, so do what we can ...	20 years ago
Tom Lane	d780f07ac1	Adjust scan plan nodes to avoid getting an extra AccessShareLock on a ... relation if it's already been locked by execMain.c as either a result relation or a FOR UPDATE/SHARE relation. This avoids an extra trip to the shared lock manager state. Per my suggestion yesterday.	20 years ago
Tom Lane	290166f934	Teach planner and executor to handle ScalarArrayOpExpr as an indexable ... qualification when the underlying operator is indexable and useOr is true. That is, indexkey op ANY (ARRAY[...]) is effectively translated into an OR combination of one indexscan for each array element. This only works for bitmap index scans, of course, since regular indexscans no longer support OR'ing of scans. There are still some loose ends to clean up before changing 'x IN (list)' to translate as a ScalarArrayOpExpr; for instance predtest.c ought to be taught about it. But this gets the basic functionality in place.	20 years ago
Bruce Momjian	436a2956d8	Re-run pgindent, fixing a problem where comment lines after a blank ... comment line where output as too long, and update typedefs for /lib directory. Also fix case where identifiers were used as variable names in the backend, but as typedefs in ecpg (favor the backend for indenting). Backpatch to 8.1.X.	20 years ago
Bruce Momjian	1dc3498251	Standard pgindent run for 8.1.	20 years ago
Tom Lane	278bd0cc22	For some reason access/tupmacs.h has been #including utils/memutils.h, ... which is neither needed by nor related to that header. Remove the bogus inclusion and instead include the header in those C files that actually need it. Also fix unnecessary inclusions and bad inclusion order in tsearch2 files.	21 years ago
Tom Lane	db70a31294	Adjust nodeBitmapIndexscan to keep the target index opened from plan ... startup to end, rather than re-opening it in each MultiExecBitmapIndexScan call. I had foolishly thought that opening/closing wouldn't be much more expensive than a rescan call, but that was sheer brain fade. This seems to fix about half of the performance lossage reported by Sergey Koposov. I'm still not sure where the other half went.	21 years ago
Tom Lane	5b05185262	Remove support for OR'd indexscans internal to a single IndexScan plan ... node, as this behavior is now better done as a bitmap OR indexscan. This allows considerable simplification in nodeIndexscan.c itself as well as several planner modules concerned with indexscan plan generation. Also we can improve the sharing of code between regular and bitmap indexscans, since they are now working with nigh-identical Plan nodes.	21 years ago
Tom Lane	186655e9a5	Adjust nodeBitmapIndexscan.c to not keep the index open across calls, ... but just to open and close it during MultiExecBitmapIndexScan. This avoids acquiring duplicate resources (eg, multiple locks on the same relation) in a tree with many bitmap scans. Also, don't bother to lock the parent heap at all here, since we must be underneath a BitmapHeapScan node that will be holding a suitable lock.	21 years ago
Tom Lane	8403741796	Actually, nodeBitmapIndexscan.c doesn't need to create a standard ... ExprContext at all, since it never evaluates any qual or tlist expressions.	21 years ago
Tom Lane	9b5b9616f4	Remove explicit FreeExprContext calls during plan node shutdown. The ... ExprContexts will be freed anyway when FreeExecutorState() is reached, and letting that routine do the work is more efficient because it will automatically free the ExprContexts in reverse creation order. The existing coding was effectively freeing them in exactly the worst possible order, resulting in O(N^2) behavior inside list_delete_ptr, which becomes highly visible in cases with a few thousand plan nodes. ExecFreeExprContext is now effectively a no-op and could be removed, but I left it in place in case we ever want to put it back to use.	21 years ago
Tom Lane	bc843d3960	First cut at planner support for bitmap index scans. Lots to do yet, ... but the code is basically working. Along the way, rewrite the entire approach to processing OR index conditions, and make it work in join cases for the first time ever. orindxpath.c is now basically obsolete, but I left it in for the time being to allow easy comparison testing against the old implementation.	21 years ago
Tom Lane	9d64632144	Minor performance improvement: avoid unnecessary creation/unioning of ... bitmaps for multiple indexscans. Instead just let each indexscan add TIDs directly into the BitmapOr node's result bitmap.	21 years ago
Tom Lane	4a8c5d0375	Create executor and planner-backend support for decoupled heap and index ... scans, using in-memory tuple ID bitmaps as the intermediary. The planner frontend (path creation and cost estimation) is not there yet, so none of this code can be executed. I have tested it using some hacked planner code that is far too ugly to see the light of day, however. Committing now so that the bulk of the infrastructure changes go in before the tree drifts under me.	21 years ago