postgres

Commit Graph

Author	SHA1	Message	Date
Tom Lane	220db7ccd8	Simplify and standardize conversions between TEXT datums and ordinary C strings. This patch introduces four support functions cstring_to_text, cstring_to_text_with_len, text_to_cstring, and text_to_cstring_buffer, and two macros CStringGetTextDatum and TextDatumGetCString. A number of existing macros that provided variants on these themes were removed. Most of the places that need to make such conversions now require just one function or macro call, in place of the multiple notational layers that used to be needed. There are no longer any direct calls of textout or textin, and we got most of the places that were using handmade conversions via memcpy (there may be a few still lurking, though). This commit doesn't make any serious effort to eliminate transient memory leaks caused by detoasting toasted text objects before they reach text_to_cstring. We changed PG_GETARG_TEXT_P to PG_GETARG_TEXT_PP in a few places where it was easy, but much more could be done. Brendan Jurd and Tom Lane	18 years ago
Tom Lane	4608f359a6	Fix a passel of signed vs unsigned char warnings.	18 years ago
Tom Lane	234a02b2a8	Replace direct assignments to VARATT_SIZEP(x) with SET_VARSIZE(x, len). Get rid of VARATT_SIZE and VARATT_DATA, which were simply redundant with VARSIZE and VARDATA, and as a consequence almost no code was using the longer names. Rename the length fields of struct varlena and various derived structures to catch anyplace that was accessing them directly; and clean up various places so caught. In itself this patch doesn't change any behavior at all, but it is necessary infrastructure if we hope to play any games with the representation of varlena headers. Greg Stark and Tom Lane	19 years ago
Bruce Momjian	f99a569a2e	pgindent run for 8.2.	19 years ago
Tom Lane	1246d797e4	Rename xml_valid() to xml_is_well_formed(), but provide a temporary alias with the old name for backwards compatibility. Per discussion, the old name is actively wrong because validity and well-formedness have different meanings in XML.	19 years ago
Tom Lane	7ce2ff2d22	Move xml2's PG_MODULE_MAGIC block to the right source file, per Michael Fuhr.	19 years ago
Tom Lane	798e63ffb0	Remove CXT_printf/CXT1_printf macros. If anyone had found them to be of any use in the past many years, we'd have made some effort to include them in all executor node types; but in fact they were only in nodeAppend.c and nodeIndexscan.c, up until I copied nodeIndexscan.c's occurrence into the new bitmap node types. Remove some other unused macros in execdebug.h, too. Some day the whole header probably ought to go away in favor of better-designed facilities.	19 years ago
Neil Conway	0d9742f99a	Attached is a patch that replaces a bunch of places where StringInfos are unnecessarily allocated on the heap rather than the stack. If the StringInfo doesn't outlive the stack frame in which it is created, there is no need to allocate it on the heap via makeStringInfo() -- stack allocation is faster. While it's not a big deal unless the code is in a critical path, I don't see a reason not to save a few cycles -- using stack allocation is not less readable. I also cleaned up a bit of code along the way: moved variable declarations into a more tightly-enclosing scope where possible, fixed some pointless copying of strings in dblink, etc.	20 years ago
Neil Conway	8e5a10d46c	This patch makes the error message strings throughout the backend more compliant with the error message style guide. In particular, errdetail should begin with a capital letter and end with a period, whereas errmsg should not. I also fixed a few related issues in passing, such as fixing the repeated misspelling of "lexeme" in contrib/tsearch2 (per Tom's suggestion).	20 years ago
Bruce Momjian	1dc3498251	Standard pgindent run for 8.1.	20 years ago
Tom Lane	be3aa30da3	Fix inadequate error checking: you can't assume that fcinfo->resultinfo is a ReturnSetInfo unless you've tested it with IsA.	20 years ago
Tom Lane	0549de06ba	Fix segfault when xpath_list function is applied to an invalid document. John Gray	21 years ago
Bruce Momjian	1646586271	Attached is a patch that adds the function xml_encode_special_chars to the xml2 contrib module. It's against 8.0beta4. It's intended for commit. Markus Bertheau <twanger@bluetwanger.de>	21 years ago
Neil Conway	04a1a24e9c	Cleanup some unnecessary void * casts when using pfree() in contrib/xml and contrib/xml2	21 years ago
Bruce Momjian	b6b71b85bc	Pgindent run for 8.0.	21 years ago
Neil Conway	bab4269b95	contrib/xml2 updates from John Gray: I have changed the name of the new parse function to xml_valid and fixed a reference to SortMem which meant that the code as supplied would work against 7.3 and 7.4 but wouldn't work in CVS.	22 years ago
Bruce Momjian	31f4b59a46	Move new version of contrib/ xml into xml2, keep old version in /xml.	22 years ago
Bruce Momjian	adca025c9e	Thanks to the generous support of Torchbox (http://www.torchbox.com ), I have been able to significantly improve the contrib/xml XPath integration code. New features: * XPath set-returning function allows multiple results from an several XPath queries to be used as a virtual table. * Using libxslt, XSLT transformations (with and without parameters) are supported. (Caution: This support allows generic URL fetching from within the backend as well). I've removed the old code so that it is all libxml based. Rather than attach as a patch, I've put the tar.gz (10k!) at http://www.azuli.co.uk/pgxml-1.0.tar.gz (all files in archive are xml/....). I think this is worth replacing the contrib version with, even though the function names have changed (though the same functionality is there), because it includes a SRF and some SPI usage, in addition to linking to an external library. And it isn't a big module! Obviously, I understand that people might prefer to move it elsewhere, or might have reservations about replacing an existing contrib module with an incompatible one. I'm open to suggestions. John Gray	22 years ago

17 Commits (c111a7211f758dbcc70fb392aa0949748cadb1e4)