20 Commits (c4ccc6146bfe2d20140da2e388e0d62b41c96f9b)

Author	SHA1	Message	Date
Bruce Momjian	5383b5d8ed	Okay, I have some new code in place that hopefully should work better. I ... couldn't produce a full patch using cvs diff -c this time since I have created new files and anonymous cvs usage doesn't allow you to adds. I'm supplying the modified src/interfaces/jdbc as a tarball at : http://www.candleweb.no/~gunnar/projects/pgsql/postgres-jdbc-2000-10-05.tgz The new files that should be added are : ? org/postgresql/PGStatement.java ? org/postgresql/ObjectPool.java ? org/postgresql/ObjectPoolFactory.java There is now a global static pool of free byte arrays and used byte arrays connected to a statement object. This is the role of the new PGStatement class. Access to the global free array is synchronized, while we rely on the PG_Stream synchronization for the used array. My measurements show that the perfomance boost on this code is not quite as big as my last shot, but it is still an improvement. Maybe some of the difference is due to the new synchronization on the global array. I think I will look into choosing between on a connection level and global level. I have also started experimented with improving the performance of the various conversions. The problem here is ofcourse related handle the various encodings. One thing I found to speed up ResultSet.getInt() a lot was to do custom conversion on the byte array into int instead of going through the getString() to do the conversion. But I'm unsure if this is portable, can we assume that a digit never can be represented by more than one byte ? It works fine in my iso-latin-8859-1 environment, but what about other environments ? Maybe we could provide different ResultSet implementations depending on the encoding used or delegate some methods of the result set to an "converter class". Check the org/postgresql/jdbc2/FastResultSet.java in the tarball above to see the modified getInt() method. Regards, Gunnar	26 years ago
Bruce Momjian	339ce34b87	As if my JDBC patch hasn't already caused enough grief, there is now a ... one-line change necessary. Due to the Mark Holloman "New Relkind for Views" patch, my support for views in the driver will need to be updated to match. The change to DatabaseMetaData.getTableTypes[][] is as follows: - {"VIEW", "(relkind='r' and relhasrules='t' and relname !~ '^pg_' and relname !~ '^xinv')"}, + {"VIEW", "(relkind='v' and relname !~ '^pg_' and relname !~ '^xinv')"}, Christopher Cain	26 years ago
Bruce Momjian	aebfaf7861	Attached is a patch that prevents a NullPointerException in the JDBC ... driver if the translations files have not been properly installed. (We carefully avoided installing the translations file in a controlled environment here specifically to test for such a bug. :-) See attached description for more details. William -- William Webber william@peopleweb.net.au	26 years ago
Bruce Momjian	7f171b599a	This patch implements the following command: ... ALTER TABLE <tablename> OWNER TO <username> Only a superuser may execute the command. -- Mark Hollomon mhh@mindspring.com	26 years ago
Bruce Momjian	65edb54186	Attached are a patch to allow the charset encoding used by the JDBC ... driver to be set, and a description of said patch. Please refer to the latter for more information. William -- William Webber william@peopleweb.net.au	26 years ago
Bruce Momjian	4f5cdadf03	Applied to jdbc1 and jdbc2. ... This is a patch which lets the DatabaseMetaData return the object type when getTables(....) is called. It does not really fix any bug, but it fills in some functionality that should be there anyway. The diff included here is off of the CVS as of just now :) ---------------------------------------------------------------- Travis Bauer | CS Grad Student | IU |www.cs.indiana.edu/~trbauer ----------------------------------------------------------------	26 years ago
Bruce Momjian	879639b5be	This patch for the 7.0.2 JDBC interface addresses four issues I ... encountered while getting my reporting tool up and running with the driver. All changes are in the DatabaseMetaData class. Problem: The getDatabaseProductVersion() method was returning "6.5.2" Resolution: Changed it to return "7.0.2" Problem: A call to getTables() with an unsupported table type (in the String array) resulted in a malformed SQL statement and subsequent parsing error Resolution: Unsupported table types are now ignored without error Problem: In a getTables() call, tables and views were both returned by the "TABLE" table type, and the "VIEW" table type was unsupported Resolution: Changed the "TABLE" type to return only physical tables and added support for the "VIEW" table type (returning only views) Problem: The getIdentifierQuoteString() method was returning null Resolution: This method now returns a double-quote Christopher Cain	26 years ago
Peter Mount	9eddc7519d	Fixed DatabaseMetaData.getTableTypes()	26 years ago
Bruce Momjian	d3ef753686	This patch fixes the 0-based/1-based result set indexing problem for ... absolute. It also makes it more compliant with the interface specification in Sun's documentation; 1. absolute(0) should throw an exception. 2. absolute(>num-records) should set the current row to after the last record in addition to returning false. 3. absolute(<num-records) should set the current row to before the first record in addition to returning false. These operations in the existing code just return false and don't change current_row. These changes required a minor change to relative(int) since it calls absolute(int) The attached patch is against the cvs repository tree as of this morning. Also, who is in charge of maintaining the jdbc driver? I'm working on getArray for the jdbc2 driver, but it's going to require three more classes to be added to the driver, and thus three more source files in the repository. Is there someone I can contact directly to ask about this? Travis Bauer | CS Grad Student | IU |www.cs.indiana.edu/~trbauer	26 years ago
Bruce Momjian	d42f9b59e9	Here is a patch for interfaces/jdbc/org/postgresql/jdbc2/ResultSet.java ... It addresses three issues: 1. The problem with ResultSet's interface specifying 1-based indexing was not quite fixed in 7.0.2. absolute would stop the user form moving to the first record (record 0 internally). 2. Absolute did not set current_row 3. For field.mod=-1, GetObject would try to return numeric values with a precision of around 65000. Now GetObject detects when field.mod==-1, and passes that as the scale to getBigDecimal. getBigDecimal detects when a -1 is passed and simply does not scale the value returned. You still get the correct value back, it simply does not tweak the precision. I'm working off of a source tree I just checked out from the repository. The diff is based on what was in the repository about ten minutes ago. ---------------------------------------------------------------- Travis Bauer | CS Grad Student | IU |www.cs.indiana.edu/~trbauer ----------------------------------------------------------------	26 years ago
Peter Mount	e3cc370d15	Added org/postgresql/DriverClass.java to the list of files removed by make clean (it's dynamically built) ... Fixed Statement, so that the update count is valid when an SQL DELETE operation is done. While fixing the update count, made it easier to get the OID of the last insert as well. Example is in example/basic.java	26 years ago
Peter Mount	0e38f0a1d1	Added some missing org.'s that prevented the use of the geometric types	26 years ago
Peter Mount	d7dbba2659	Removed hardwired 8k limit on queries	26 years ago
Peter Mount	228a5e708c	Removed timezone in ResultSet.getTimestamp()	26 years ago
Bruce Momjian	2cfb14e8ea	Fix the off by one errors in ResultSet from 6.5.3, and more. ... I'm including a diff of postgresql-7.0/src/interfaces/jdbc/org/postgresql/jdbc2/ResultSet.java. I've clearly marked all the fixes I did. Would *someone* who has access to the cvs please put this in? Joseph Shraibman	26 years ago
Peter Mount	86b8bd0748	Minor fixes ready for 7.0	26 years ago
Bruce Momjian	f839762e0b	Remove DriverClass.java. It is generated by the compile.	26 years ago
Bruce Momjian	0b65e1436e	Add res clear to example	26 years ago
Peter Mount	4fc3690238	Attempt III	26 years ago
Peter Mount	25dadc8514	Another attempt at 7.0	26 years ago