59 Commits (dce429b117be027f059bb9df5c76eb5eadcc456d)

Author	SHA1	Message	Date
Tom Lane	cc3f281ffb	Fix postgres_fdw's issues with inconsistent interpretation of data values. ... For datatypes whose output formatting depends on one or more GUC settings, we have to worry about whether the other server will interpret the value the same way it was meant. pg_dump has been aware of this hazard for a long time, but postgres_fdw needs to deal with it too. To fix data retrieval from the remote server, set the necessary remote GUC settings at connection startup. (We were already assuming that settings made then would persist throughout the remote session.) To fix data transmission to the remote server, temporarily force the relevant GUCs to the right values when we're about to convert any data values to text for transmission. This is all pretty grotty, and not very cheap either. It's tempting to think of defining one uber-GUC that would override any settings that might render printed data values unportable. But of course, older remote servers wouldn't know any such thing and would still need this logic. While at it, revert commit f7951eef89, since this provides a real fix. (The timestamptz given in the error message returned from the "remote" server will now reliably be shown in UTC.)	13 years ago
Tom Lane	f7951eef89	Band-aid for regression test expected-results problem with timestamptz. ... We probably need to tell the remote server to use specific timezone and datestyle settings, and maybe other things. But for now let's just hack the postgres_fdw regression test to not provoke failures when run in non-EST5EDT environments. Per buildfarm.	13 years ago
Tom Lane	21734d2fb8	Support writable foreign tables. ... This patch adds the core-system infrastructure needed to support updates on foreign tables, and extends contrib/postgres_fdw to allow updates against remote Postgres servers. There's still a great deal of room for improvement in optimization of remote updates, but at least there's basic functionality there now. KaiGai Kohei, reviewed by Alexander Korotkov and Laurenz Albe, and rather heavily revised by Tom Lane.	13 years ago
Tom Lane	09a7cd409e	Rename postgres_fdw's use_remote_explain option to use_remote_estimate. ... The new name was originally my typo, but per discussion it seems like a better name anyway. So make the code match the docs, not vice versa.	13 years ago
Tom Lane	6da378dbc9	Fix whole-row references in postgres_fdw. ... The optimization to not retrieve unnecessary columns wasn't smart enough. Noted by Thom Brown.	13 years ago
Tom Lane	211e157a51	Change postgres_fdw to show casts as casts, not underlying function calls. ... On reflection this method seems to be exposing an unreasonable amount of implementation detail. It wouldn't matter when talking to a remote server of the identical Postgres version, but it seems likely to make things worse not better if the remote is a different version with different casting infrastructure. Instead adopt ruleutils.c's policy of regurgitating the cast as it was originally specified; including not showing it at all, if it was implicit to start with. (We must do that because for some datatypes explicit and implicit casts have different semantics.)	13 years ago
Tom Lane	5fd386bb31	Get rid of postgres_fdw's assumption that remote type OIDs match ours. ... The only place we depended on that was in sending numeric type OIDs in PQexecParams; but we can replace that usage with explicitly casting each Param symbol in the query string, so that the types are specified to the remote by name not OID. This makes no immediate difference but will be essential if we ever hope to support use of non-builtin types.	13 years ago
Tom Lane	6d06049493	Adjust postgres_fdw's search path handling. ... Set the remote session's search path to exactly "pg_catalog" at session start, then schema-qualify only names that aren't in that schema. This greatly reduces clutter in the generated SQL commands, as seen in the regression test changes. Per discussion. Also, rethink use of FirstNormalObjectId as the "built-in object" cutoff --- FirstBootstrapObjectId is safer, since the former will accept objects in information_schema for instance.	13 years ago
Tom Lane	d0d75c4022	Add postgres_fdw contrib module. ... There's still a lot of room for improvement, but it basically works, and we need this to be present before we can do anything much with the writable-foreign-tables patch. So let's commit it and get on with testing. Shigeru Hanada, reviewed by KaiGai Kohei and Tom Lane	13 years ago