3 Commits (ecacbdbcee67e202cfcaa1180da170b9f13654bb)

Author	SHA1	Message	Date
Tom Lane	458857cc9d	Throw a useful error message if an extension script file is fed to psql. ... We have seen one too many reports of people trying to use 9.1 extension files in the old-fashioned way of sourcing them in psql. Not only does that usually not work (due to failure to substitute for MODULE_PATHNAME and/or @extschema@), but if it did work they'd get a collection of loose objects not an extension. To prevent this, insert an \echo ... \quit line that prints a suitable error message into each extension script file, and teach commands/extension.c to ignore lines starting with \echo. That should not only prevent any adverse consequences of loading a script file the wrong way, but make it crystal clear to users that they need to do it differently now. Tom Lane, following an idea of Andrew Dunstan's. Back-patch into 9.1 ... there is not going to be much value in this if we wait till 9.2.	14 years ago
Tom Lane	029fac2264	Avoid use of CREATE OR REPLACE FUNCTION in extension installation files. ... It was never terribly consistent to use OR REPLACE (because of the lack of comparable functionality for data types, operators, etc), and experimentation shows that it's now positively pernicious in the extension world. We really want a failure to occur if there are any conflicts, else it's unclear what the extension-ownership state of the conflicted object ought to be. Most of the time, CREATE EXTENSION will fail anyway because of conflicts on other object types, but an extension defining only functions can succeed, with bad results.	15 years ago
Tom Lane	629b3af27d	Convert contrib modules to use the extension facility. ... This isn't fully tested as yet, in particular I'm not sure that the "foo--unpackaged--1.0.sql" scripts are OK. But it's time to get some buildfarm cycles on it. sepgsql is not converted to an extension, mainly because it seems to require a very nonstandard installation process. Dimitri Fontaine and Tom Lane	15 years ago
Tom Lane	541fc3d4df	Ooops, forgot to fix contrib/tsearch2's references to GIN support funcs.	15 years ago
Peter Eisentraut	fc946c39ae	Remove useless whitespace at end of lines	15 years ago
Magnus Hagander	9f2e211386	Remove cvs keywords from all files.	15 years ago
Tom Lane	87b8db3774	Adjust the APIs for GIN opclass support functions to allow the extractQuery() ... method to pass extra data to the consistent() and comparePartial() methods. This is the core infrastructure needed to support the soon-to-appear contrib/btree_gin module. The APIs are still upward compatible with the definitions used in 8.3 and before, although *not* with the previous 8.4devel function definitions. catversion bump for changes in pg_proc entries (although these are just cosmetic, since GIN doesn't actually look at the function signature before calling it...) Teodor Sigaev and Oleg Bartunov	17 years ago
Tom Lane	8461ab5ab1	Update contrib for tsearch changes.	18 years ago
Tom Lane	9b5c8d45f6	Push index operator lossiness determination down to GIST/GIN opclass ... "consistent" functions, and remove pg_amop.opreqcheck, as per recent discussion. The main immediate benefit of this is that we no longer need 8.3's ugly hack of requiring @@@ rather than @@ to test weight-using tsquery searches on GIN indexes. In future it should be possible to optimize some other queries better than is done now, by detecting at runtime whether the index match is exact or not. Tom Lane, after an idea of Heikki's, and with some help from Teodor.	18 years ago
Tom Lane	11fccbeaeb	Adjust the names of a couple of tsearch index support functions that had ... inappropriately generic-sounding names. This is more or less free since we already forced initdb for the next beta, and it may prevent confusion or name conflicts (particularly at the C-global-symbol level) down the road. Per my proposal yesterday.	18 years ago
Tom Lane	f00d75b8d7	Add snb_ru_init(internal) to list of stub functions in tsearch2 ... compatibility module. Needed to support loading of 8.1-era tsearch2 configuration data.	18 years ago
Tom Lane	4394c1b09c	Resurrect the code for the rewrite(ARRAY[...]) aggregate function, ... and put it into contrib/tsearch2 compatibility module.	18 years ago
Tom Lane	90e3f2aca7	Replace the now-incompatible-with-core contrib/tsearch2 module with a ... compatibility package. This supports importing dumps from past versions using tsearch2, and provides the old names and API for most functions that were changed. (rewrite(ARRAY[...]) is a glaring omission, though.) Pavel Stehule and Tom Lane	18 years ago