59 Commits (f339a998ffe6fb8aa8c114a33316e97b56cb1513)

Author	SHA1	Message	Date
Tom Lane	8fd5b3ed67	Error message editing in contrib (mostly by Joe Conway --- thanks Joe!)	23 years ago
Bruce Momjian	7b1f6ffaab	Jim C. Nasby wrote: ... > Second argument to metaphone is suposed to set the limit on the > number of characters to return, but it breaks on some phrases: > > usps=# select metaphone(a,3),metaphone(a,4),metaphone(a,20) from > (select 'Hello world'::varchar AS a) a; > HLW | HLWR | HLWRLT > > usps=# select metaphone(a,3),metaphone(a,4),metaphone(a,20) from > (select 'A A COMEAUX MEMORIAL'::varchar AS a) a; > AKM | AKMKS | AKMKSMMRL > > In every case I've found that does this, the 4th and 5th letters are > always 'KS'. Nice catch. There was a bug in the original metaphone algorithm from CPAN. Patch attached (while I was at it I updated my email address, changed the copyright to PGDG, and removed an unnecessary palloc). Here's how it looks now: regression=# select metaphone(a,4) from (select 'A A COMEAUX MEMORIAL'::varchar AS a) a; metaphone ----------- AKMK (1 row) regression=# select metaphone(a,5) from (select 'A A COMEAUX MEMORIAL'::varchar AS a) a; metaphone ----------- AKMKS (1 row) Joe Conway	23 years ago
Tom Lane	e4704001ea	This patch fixes a bunch of spelling mistakes in comments throughout the ... PostgreSQL source code. Neil Conway	23 years ago
Tom Lane	ee051baeac	Make sure that all <ctype.h> routines are called with unsigned char ... values; it's not portable to call them with signed chars. I recall doing this for the last release, but a few more uncasted calls have snuck in.	24 years ago
Bruce Momjian	cd01c32f55	Add trailing semicolon for Joe Conway	24 years ago
Bruce Momjian	b81844b173	pgindent run on all C files. Java run to follow. initdb/regression ... tests pass.	25 years ago
Bruce Momjian	fde8edaf53	Add do { ... } while (0) to more bad macros.	25 years ago
Bruce Momjian	cdd02cdf00	Sorry - I should have gotten to this sooner. Here's a patch which you should ... be able to apply against what you just committed. It rolls soundex into fuzzystrmatch. Remove soundex/metaphone and merge into fuzzystrmatch. Joe Conway	25 years ago
Bruce Momjian	d8783c512e	Per this discussion, here's a patch to implement both levenshtein() and ... metaphone() in a contrib. There seem to be a fair number of different approaches to both of these algorithms. I used the simplest case for levenshtein which has a cost of 1 for any character insertion, deletion, or substitution. For metaphone, I adapted the same code from CPAN that the PHP folks did. A couple of questions: 1. Does it make sense to fold the soundex contrib together with this one? 2. I was debating trying to add multibyte support to levenshtein (it would make no sense at all for metaphone), but a quick search through the contrib directory found no hits on the word MULTIBYTE. Should worry about adding multibyte support to levenshtein()? Joe Conway	25 years ago