You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 2cd2222ca5 Avoid resource leaks when a dblink connection fails. ... If we hit out-of-memory between creating the PGconn and inserting it into dblink's hashtable, we'd lose track of the PGconn, which is quite bad since it represents a live connection to a remote DB. Fix by rearranging things so that we create the hashtable entry first. Also reduce the number of states we have to deal with by getting rid of the separately-allocated remoteConn object, instead allocating it in-line in the hashtable entries. (That incidentally removes a session-lifespan memory leak observed in the regression tests.) There is an apparently-irreducible remaining OOM hazard, which is that if the connection fails at the libpq level (ie it's CONNECTION_BAD) then we have to pstrdup the PGconn's error message before we can release it, and theoretically that could fail. However, in such cases we're only leaking memory not a live remote connection, so I'm not convinced that it's worth sweating over. This is a pretty low-probability failure mode of course, but losing a live connection seems bad enough to justify back-patching. Author: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Matheus Alcantara <matheusssilv97@gmail.com> Discussion: https://postgr.es/m/1346940.1748381911@sss.pgh.pa.us Backpatch-through: 13		4 months ago
..
expected	Revert use singular for -1 (commits 9ee7d533da and 5da9868ed9	4 years ago
input	Use setenv() in preference to putenv().	5 years ago
output	Use setenv() in preference to putenv().	5 years ago
sql	…
.gitignore	…
Makefile	Remove support for upgrading extensions from "unpackaged" state.	6 years ago
dblink--1.0--1.1.sql	…
dblink--1.1--1.2.sql	…
dblink--1.2.sql	…
dblink.c	Avoid resource leaks when a dblink connection fails.	4 months ago
dblink.control	…
pg_service.conf	…