You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 9a299cf7c2 Replace RelationOpenSmgr() with RelationGetSmgr(). ... This is a back-patch of the v15-era commit f10f0ae42 into older supported branches. The idea is to design out bugs in which an ill-timed relcache flush clears rel->rd_smgr partway through some code sequence that wasn't expecting that. We had another report today of a corner case that reliably crashes v14 under debug_discard_caches (nee CLOBBER_CACHE_ALWAYS), and therefore would crash once in a blue moon in the field. We're unlikely to get rid of all such code paths unless we adopt the more rigorous coding rules instituted by f10f0ae42. Therefore, even though this is a bit invasive, it's time to back-patch. Some comfort can be taken in the fact that f10f0ae42 has been in v15 for 16 months without problems. I left the RelationOpenSmgr macro present in the back branches, even though no core code should use it anymore, in order to not break third-party extensions in minor releases. Such extensions might opt to start using RelationGetSmgr instead, to reduce their code differential between v15 and earlier branches. This carries a hazard of failing to compile against headers from existing minor releases. However, once compiled the extension should work fine even with such releases, because RelationGetSmgr is a "static inline" function so it creates no link-time dependency. So depending on distribution practices, that might be an OK tradeoff. Per report from Spyridon Dimitrios Agathos. Original patch by Amul Sul. Discussion: https://postgr.es/m/CAFM5RaqdgyusQvmWkyPYaWMwoK5gigdtW-7HcgHgOeAw7mqJ_Q@mail.gmail.com Discussion: https://postgr.es/m/CANiYTQsU7yMFpQYnv=BrcRVqK_3U3mtAzAsJCaqtzsDHfsUbdQ@mail.gmail.com		3 years ago
..
expected	Make relation-enumerating operations be security-restricted operations.	3 years ago
sql	Make relation-enumerating operations be security-restricted operations.	3 years ago
t	Introduce PG_TEST_TIMEOUT_DEFAULT for TAP suite non-elapsing timeouts.	4 years ago
.gitignore	…
Makefile	Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY.	4 years ago
amcheck--1.0--1.1.sql	Add amcheck verification of heap relations belonging to btree indexes.	8 years ago
amcheck--1.0.sql	…
amcheck--1.1--1.2.sql	Allow amcheck to re-find tuples using new search.	7 years ago
amcheck.control	Allow amcheck to re-find tuples using new search.	7 years ago
verify_nbtree.c	Replace RelationOpenSmgr() with RelationGetSmgr().	3 years ago