You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Nathan Bossart 079480dc20 Fix lookup code for REINDEX INDEX. ... This commit adjusts RangeVarCallbackForReindexIndex() to handle an extremely unlikely race condition involving concurrent OID reuse. In short, if REINDEX INDEX is executed at the same time that the index is re-created with the same name and OID but a different parent table OID, we might lock the wrong parent table. To fix, simply detect when this happens and emit an ERROR. Unfortunately, we can't gracefully handle this situation because we will have already locked the index, and we must lock the parent table before the index to avoid deadlocks. While at it, I've replaced all but one early return in this callback function with ERRORs that should be unreachable. While I haven't verified the presence of a live bug, the checks in question appear to be unnecessary, and the early returns seem prone to breaking the parent table locking code in subtle ways. If nothing else, this simplifies the code a bit. This is a bug fix and could be back-patched, but given the presumed rarity of the race condition and the lack of reports, I'm not going to bother. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Jeff Davis <pgsql@j-davis.com> Discussion: https://postgr.es/m/Z8zwVmGzXyDdkAXj%40nathan		8 months ago
..
backend	Fix lookup code for REINDEX INDEX.	8 months ago
bin	Add log_autoanalyze_min_duration	8 months ago
common	Fix compiler warnings around _CRT_glob	8 months ago
fe_utils	Introduce frontend API able to retrieve the contents of PG_VERSION	8 months ago
include	Add pg_iswalpha() and related functions.	8 months ago
interfaces	Cleanup NAN code in float.h, too.	8 months ago
makefiles	Remove traces of support for Sun Studio compiler	9 months ago
pl	plpython: Remove support for major version conflict detection	8 months ago
port	Fix incorrect message-printing in win32security.c.	8 months ago
template	Remove traces of support for Sun Studio compiler	9 months ago
test	Fix lookups in pg_{clear,restore}_{attribute,relation}_stats().	8 months ago
timezone	Generate GUC tables from .dat file	9 months ago
tools	Add log_autoanalyze_min_duration	8 months ago
tutorial	Fix compile of src/tutorial/funcs.c	8 months ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Remove traces of support for Sun Studio compiler	9 months ago
Makefile.shlib	…
meson.build	…
nls-global.mk	…