You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 7a844c77ec Fix joinclause removal logic to cope with cloned clauses. ... When we're deleting a no-op LEFT JOIN from the query, we must remove the join's joinclauses from surviving relations' joininfo lists. The invention of "cloned" clauses in 2489d76c4 broke the logic for that; it'd fail to remove clones that include OJ relids outside the doomed join's min relid sets, which could happen if that join was previously discovered to commute with some other join. This accidentally failed to cause problems in the majority of cases, because we'd never decide that such a cloned clause was evaluatable at any surviving join. However, Richard Guo discovered a case where that did happen, leading to "no relation entry for relid" errors later. Also, adding assertions that a non-removed clause contains no Vars from the doomed join exposes that there are quite a few existing regression test cases where the problem happens but is accidentally not exposed. The fix for this is just to include the target join's commute_above_r and commute_below_l sets in the relid set we test against when deciding whether a join clause is "pushed down" and thus not removable. While at it, do a little refactoring: the join's relid set can be computed inside remove_rel_from_query rather than in the caller. Patch by me; thanks to Richard Guo for review. Discussion: https://postgr.es/m/CAMbWs4_PHrRqTKDNnTRsxxQy6BtYCVKsgXm1_gdN2yQ=kmcO5g@mail.gmail.com		3 years ago
..
access	nbtree VACUUM: cope with right sibling link corruption.	3 years ago
archive	Redesign archive modules	3 years ago
backup	Pre-beta mechanical code beautification.	3 years ago
bootstrap	Fix CREATE INDEX progress reporting for multi-level partitioning.	3 years ago
catalog	Expand some more uses of "deleg" to "delegation" or "delegated".	3 years ago
commands	Pre-beta mechanical code beautification.	3 years ago
executor	Pre-beta mechanical code beautification.	3 years ago
foreign	Expand some more uses of "deleg" to "delegation" or "delegated".	3 years ago
jit	Pre-beta mechanical code beautification.	3 years ago
lib	Fix ILIST_DEBUG build	3 years ago
libpq	rename "gss_accept_deleg" to "gss_accept_delegation".	3 years ago
main	Remove obsolete defense against strxfrm() bugs.	3 years ago
nodes	Pre-beta mechanical code beautification.	3 years ago
optimizer	Fix joinclause removal logic to cope with cloned clauses.	3 years ago
parser	Pre-beta mechanical code beautification.	3 years ago
partitioning	Pre-beta mechanical code beautification.	3 years ago
po	Translation updates	3 years ago
port	Update copyright for 2023	3 years ago
postmaster	Pre-beta mechanical code beautification.	3 years ago
regex	Pre-beta mechanical code beautification.	3 years ago
replication	Optimize walsender wake up logic using condition variables	3 years ago
rewrite	Pre-beta mechanical code beautification.	3 years ago
snowball	Fix the install rule for snowball_create.sql.	3 years ago
statistics	Pre-beta mechanical code beautification.	3 years ago
storage	Remove over-eager assertion in ExtendBufferedRelTo()	3 years ago
tcop	Handle logical slot conflicts on standby	3 years ago
tsearch	Pre-beta mechanical code beautification.	3 years ago
utils	Use lower case for icu_validation_level values	3 years ago
.gitignore	…
Makefile	Redesign archive modules	3 years ago
common.mk	…
meson.build	meson: Prevent installation of test files during main install	3 years ago
nls.mk	Add missing gettext triggers	3 years ago