You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Noah Misch 0cecc908e9 Lock before setting relhassubclass on RELKIND_PARTITIONED_INDEX. ... Commit 5b562644fe added a comment that SetRelationHasSubclass() callers must hold this lock. When commit 17f206fbc8 extended use of this column to partitioned indexes, it didn't take the lock. As the latter commit message mentioned, we currently never reset a partitioned index to relhassubclass=f. That largely avoids harm from the lock omission. The cause for fixing this now is to unblock introducing a rule about locks required to heap_update() a pg_class row. This might cause more deadlocks. It gives minor user-visible benefits: - If an ALTER INDEX SET TABLESPACE runs concurrently with ALTER TABLE ATTACH PARTITION or CREATE PARTITION OF, one transaction blocks instead of failing with "tuple concurrently updated". (Many cases of DDL concurrency still fail that way.) - Match ALTER INDEX ATTACH PARTITION in choosing to lock the index. While not user-visible today, we'll need this if we ever make something set the flag to false for a partitioned index, like ANALYZE does today for tables. Back-patch to v12 (all supported versions), the plan for the commit relying on the new rule. In back branches, add LockOrStrongerHeldByMe() instead of adding a LockHeldByMe() parameter. Reviewed (in an earlier version) by Robert Haas. Discussion: https://postgr.es/m/20240611024525.9f.nmisch@google.com		2 years ago
..
Makefile	Revert: Implement pg_wal_replay_wait() stored procedure	2 years ago
aggregatecmds.c	Remove unused #include's from backend .c files	2 years ago
alter.c	Repair ALTER EXTENSION ... SET SCHEMA.	2 years ago
amcmds.c	Fix typos and duplicate words	2 years ago
analyze.c	revert: Generalize relation analyze in table AM interface	2 years ago
async.c	Remove unused typedefs	2 years ago
cluster.c	Avoid repeating loads of frozen ID values.	2 years ago
collationcmds.c	Address more review comments on commit 2d819a08a1.	2 years ago
comment.c	Update copyright for 2024	2 years ago
constraint.c	Add missing index_insert_cleanup calls	2 years ago
conversioncmds.c	Remove unused #include's from backend .c files	2 years ago
copy.c	Disallow specifying ON_ERROR option without value.	2 years ago
copyfrom.c	Fix typos and duplicate words	2 years ago
copyfromparse.c	Remove obsolete comment in CopyReadLineText().	2 years ago
copyto.c	Add RETURNING support to MERGE.	2 years ago
createas.c	Revert: Let table AM insertion methods control index insertion	2 years ago
dbcommands.c	Fix locale options checking in CREATE DATABASE.	2 years ago
define.c	Remove unused #include's from backend .c files	2 years ago
discard.c	Update copyright for 2024	2 years ago
dropcmds.c	Remove unused #include's from backend .c files	2 years ago
event_trigger.c	Fix typos with function name in event_trigger.c	2 years ago
explain.c	Fix some inconsistencies in EXPLAIN output	2 years ago
extension.c	Repair ALTER EXTENSION ... SET SCHEMA.	2 years ago
foreigncmds.c	Update copyright for 2024	2 years ago
functioncmds.c	Fix handling of polymorphic output arguments for procedures.	2 years ago
indexcmds.c	Lock before setting relhassubclass on RELKIND_PARTITIONED_INDEX.	2 years ago
lockcmds.c	Reintroduce MAINTAIN privilege and pg_maintain predefined role.	2 years ago
matview.c	Revert: Let table AM insertion methods control index insertion	2 years ago
meson.build	Revert: Implement pg_wal_replay_wait() stored procedure	2 years ago
opclasscmds.c	Remove unused #include's from backend .c files	2 years ago
operatorcmds.c	Remove unused #include's from backend .c files	2 years ago
policy.c	Remove unused #include's from backend .c files	2 years ago
portalcmds.c	Update copyright for 2024	2 years ago
prepare.c	Remove unused #include's from backend .c files	2 years ago
proclang.c	Remove unused #include's from backend .c files	2 years ago
publicationcmds.c	Revise GUC names quoting in messages again	2 years ago
schemacmds.c	Update copyright for 2024	2 years ago
seclabel.c	Update copyright for 2024	2 years ago
sequence.c	Lock owned sequences during ALTER TABLE SET { LOGGED | UNLOGGED }.	2 years ago
statscmds.c	Initialize variables to placate compiler.	2 years ago
subscriptioncmds.c	Fix the handling of the failover option in subscription commands.	2 years ago
tablecmds.c	Lock before setting relhassubclass on RELKIND_PARTITIONED_INDEX.	2 years ago
tablespace.c	Remove unused #include's from backend .c files	2 years ago
trigger.c	Don't throw an error if a queued AFTER trigger no longer exists.	2 years ago
tsearchcmds.c	Remove unused #include's from backend .c files	2 years ago
typecmds.c	Revert temporal primary keys and foreign keys	2 years ago
user.c	Remove unused #include's from backend .c files	2 years ago
vacuum.c	Revise GUC names quoting in messages again	2 years ago
vacuumparallel.c	Fix typos and duplicate words	2 years ago
variable.c	Revise GUC names quoting in messages again	2 years ago
view.c	Separate equalRowTypes() from equalTupleDescs()	2 years ago