postgres

History

Etsuro Fujita 12609fbacb Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch. If inside an EPQ recheck, ExecScanFetch would run the recheck method function for foreign/custom joins even if they aren't descendant nodes in the EPQ recheck plan tree, which is problematic at least in the foreign-join case, because such a foreign join isn't guaranteed to have an alternative local-join plan required for running the recheck method function; in the postgres_fdw case this could lead to a segmentation fault or an assert failure in an assert-enabled build when running the recheck method function. Even if inside an EPQ recheck, any scan nodes that aren't descendant ones in the EPQ recheck plan tree should be normally processed by using the access method function; fix by modifying ExecScanFetch so that if inside an EPQ recheck, it runs the recheck method function for foreign/custom joins that are descendant nodes in the EPQ recheck plan tree as before and runs the access method function for foreign/custom joins that aren't. This fix also adds to postgres_fdw an isolation test for an EPQ recheck that caused issues stated above. Oversight in commit `385f337c9`. Reported-by: Kristian Lejao <kristianlejao@gmail.com> Author: Masahiko Sawada <sawada.mshk@gmail.com> Co-authored-by: Etsuro Fujita <etsuro.fujita@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Etsuro Fujita <etsuro.fujita@gmail.com> Discussion: https://postgr.es/m/CAD21AoBpo6Gx55FBOW+9s5X=nUw3Xpq64v35fpDEKsTERnc4TQ@mail.gmail.com Backpatch-through: 13		3 months ago
..
backend	Add some const qualifiers	3 months ago
bin	pg_createsubscriber: Use new routine to retrieve data of PG_VERSION	3 months ago
common	Fix compiler warnings around _CRT_glob	3 months ago
fe_utils	Introduce frontend API able to retrieve the contents of PG_VERSION	3 months ago
include	Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.	3 months ago
interfaces	Cleanup NAN code in float.h, too.	3 months ago
makefiles	Remove traces of support for Sun Studio compiler	4 months ago
pl	plpython: Remove support for major version conflict detection	3 months ago
port	Fix incorrect message-printing in win32security.c.	3 months ago
template	Remove traces of support for Sun Studio compiler	4 months ago
test	Standardize use of REFRESH PUBLICATION in code and messages.	3 months ago
timezone	Generate GUC tables from .dat file	4 months ago
tools	Add "ALL SEQUENCES" support to publications.	3 months ago
tutorial	Fix compile of src/tutorial/funcs.c	3 months ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Remove traces of support for Sun Studio compiler	4 months ago
Makefile.shlib	…
meson.build	…
nls-global.mk	…