You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 618c16707a Rearrange libpq's error reporting to avoid duplicated error text. ... Since commit ffa2e4670, libpq accumulates text in conn->errorMessage across a whole query cycle. In some situations, we may report more than one error event within a cycle: the easiest case to reach is where we report a FATAL error message from the server, and then a bit later we detect loss of connection. Since, historically, each error PGresult bears the entire content of conn->errorMessage, this results in duplication of the FATAL message in any output that concatenates the contents of the PGresults. Accumulation in errorMessage still seems like a good idea, especially in view of the number of places that did ad-hoc error concatenation before ffa2e4670. So to fix this, let's track how much of conn->errorMessage has been read out into error PGresults, and only include new text in later PGresults. The tricky part of that is to be sure that we never discard an error PGresult once made (else we'd risk dropping some text, a problem much worse than duplication). While libpq formerly did that in some code paths, a little bit of rearrangement lets us postpone making an error PGresult at all until we are about to return it. A side benefit of that postponement is that it now becomes practical to return a dummy static PGresult in cases where we hit out-of-memory while trying to manufacture an error PGresult. This eliminates the admittedly-very-rare case where we'd return NULL from PQgetResult, indicating successful query completion, even though what actually happened was an OOM failure. Discussion: https://postgr.es/m/ab4288f8-be5c-57fb-2400-e3e857f53e46@enterprisedb.com		4 years ago
..
expected	Rearrange libpq's error reporting to avoid duplicated error text.	4 years ago
specs	Add isolation test for errors during logical slot creation.	4 years ago
sql	Fix skip-empty-xacts with sequences in test_decoding	4 years ago
t	Replace Test::More plans with done_testing	4 years ago
.gitignore	Improve isolation tests infrastructure.	9 years ago
Makefile	Add isolation test for errors during logical slot creation.	4 years ago
logical.conf	Add logical_decoding_work_mem to limit ReorderBuffer memory usage.	6 years ago
test_decoding.c	Fix skip-empty-xacts with sequences in test_decoding	4 years ago