You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 1e7c4bb004 Change unknown-type literals to type text in SELECT and RETURNING lists. ... Previously, we left such literals alone if the query or subquery had no properties forcing a type decision to be made (such as an ORDER BY or DISTINCT clause using that output column). This meant that "unknown" could be an exposed output column type, which has never been a great idea because it could result in strange failures later on. For example, an outer query that tried to do any operations on an unknown-type subquery output would generally fail with some weird error like "failed to find conversion function from unknown to text" or "could not determine which collation to use for string comparison". Also, if the case occurred in a CREATE VIEW's query then the view would have an unknown-type column, causing similar failures in queries trying to use the view. To fix, at the tail end of parse analysis of a query, forcibly convert any remaining "unknown" literals in its SELECT or RETURNING list to type text. However, provide a switch to suppress that, and use it in the cases of SELECT inside a set operation or INSERT command. In those cases we already had type resolution rules that make use of context information from outside the subquery proper, and we don't want to change that behavior. Also, change creation of an unknown-type column in a relation from a warning to a hard error. The error should be unreachable now in CREATE VIEW or CREATE MATVIEW, but it's still possible to explicitly say "unknown" in CREATE TABLE or CREATE (composite) TYPE. We want to forbid that because it's nothing but a foot-gun. This change creates a pg_upgrade failure case: a matview that contains an unknown-type column can't be pg_upgraded, because reparsing the matview's defining query will now decide that the column is of type text, which doesn't match the cstring-like storage that the old materialized column would actually have. Add a checking pass to detect that. While at it, we can detect tables or composite types that would fail, essentially for free. Those would fail safely anyway later on, but we might as well fail earlier. This patch is by me, but it owes something to previous investigations by Rahila Syed. Also thanks to Ashutosh Bapat and Michael Paquier for review. Discussion: https://postgr.es/m/CAH2L28uwwbL9HUM-WR=hromW1Cvamkn7O-g8fPY2m=_7muJ0oA@mail.gmail.com		9 years ago
..
.gitignore	…
abstime.sql	…
advisory_lock.sql	…
aggregates.sql	Fix sharing Agg transition state of DISTINCT or ordered aggs.	9 years ago
alter_generic.sql	Establish conventions about global object names used in regression tests.	10 years ago
alter_operator.sql	Establish conventions about global object names used in regression tests.	10 years ago
alter_table.sql	Teach partitioning tests not to use DROP TABLE ... CASCADE.	9 years ago
amutils.sql	Add SQL-accessible functions for inspecting index AM properties.	10 years ago
arrays.sql	Fix handling of empty arrays in array_fill().	9 years ago
async.sql	Add new function pg_notification_queue_usage.	11 years ago
bit.sql	…
bitmapops.sql	…
boolean.sql	Clean up references to SQL92	13 years ago
box.sql	Get rid of minus zero in box regression test.	10 years ago
brin.sql	Make core regression tests safe for Danish locale.	10 years ago
btree_index.sql	Add test cases for indexam operations not currently covered.	11 years ago
case.sql	Fix handling of expanded objects in CoerceToDomain and CASE execution.	9 years ago
char.sql	…
circle.sql	…
cluster.sql	Establish conventions about global object names used in regression tests.	10 years ago
collate.linux.utf8.sql	Support range data types.	14 years ago
collate.sql	Show sort ordering options in EXPLAIN output.	11 years ago
combocid.sql	Fix locking a tuple updated by an aborted (sub)transaction	9 years ago
comments.sql	…
conversion.sql	Establish conventions about global object names used in regression tests.	10 years ago
copy2.sql	Support "COPY view FROM" for views with INSTEAD OF INSERT triggers.	9 years ago
copydml.sql	COPY (INSERT/UPDATE/DELETE .. RETURNING ..)	10 years ago
copyselect.sql	Have \copy go through SendQuery	14 years ago
create_aggregate.sql	Fix type-safety problem with parallel aggregate serial/deserialization.	10 years ago
create_am.sql	Fix broken dependency-mongering for index operator classes/families.	10 years ago
create_cast.sql	Make CREATE TYPE print warnings if a datatype's I/O functions are volatile.	11 years ago
create_function_3.sql	Establish conventions about global object names used in regression tests.	10 years ago
create_index.sql	Reset the proper GUC in create_index test.	9 years ago
create_misc.sql	…
create_operator.sql	Allow named parameters to be specified using => in addition to :=	11 years ago
create_table.sql	Change unknown-type literals to type text in SELECT and RETURNING lists.	9 years ago
create_table_like.sql	Fix CREATE TABLE ... LIKE ... WITH OIDS.	9 years ago
create_type.sql	Fix pg_dump to dump shell types.	11 years ago
create_view.sql	Change unknown-type literals to type text in SELECT and RETURNING lists.	9 years ago
date.sql	Allow negative years in make_date to represent BC years	9 years ago
dbsize.sql	Add pg_size_bytes() to parse human-readable size strings.	10 years ago
delete.sql	…
dependency.sql	Establish conventions about global object names used in regression tests.	10 years ago
domain.sql	Avoid caching expression state trees for domain constraints across queries.	10 years ago
drop_if_exists.sql	Establish conventions about global object names used in regression tests.	10 years ago
drop_operator.sql	Fix DROP OPERATOR to reset oprcom/oprnegate links to the dropped operator.	10 years ago
enum.sql	Support renaming an existing value of an enum type.	9 years ago
equivclass.sql	Improve RLS planning by marking individual quals with security levels.	9 years ago
errors.sql	Allow empty target list in SELECT.	12 years ago
event_trigger.sql	Establish conventions about global object names used in regression tests.	10 years ago
float4.sql	…
float8.sql	Improve regression tests for degree-based trigonometric functions.	10 years ago
foreign_data.sql	Establish conventions about global object names used in regression tests.	10 years ago
foreign_key.sql	Check for pending trigger events on far end when dropping an FK constraint.	9 years ago
functional_deps.sql	…
geometry.sql	Add geometry/range functions to support BRIN inclusion	11 years ago
gin.sql	Make GIN regression test stable.	10 years ago
gist.sql	Fix potential platform dependence in gist regression test.	11 years ago
groupingsets.sql	Fix overeager pushdown of HAVING clauses when grouping sets are used.	10 years ago
guc.sql	Establish conventions about global object names used in regression tests.	10 years ago
hash_index.sql	Improve regression test coverage for hash indexes.	9 years ago
horology.sql	Make to_timestamp() and to_date() range-check fields of their input.	9 years ago
hs_primary_extremes.sql	…
hs_primary_setup.sql	…
hs_standby_allowed.sql	Better fix for sequence access in hot standby test	9 years ago
hs_standby_check.sql	…
hs_standby_disallowed.sql	…
hs_standby_functions.sql	…
indirect_toast.sql	Add support for multiple kinds of external toast datums.	13 years ago
inet.sql	Create an SP-GiST opclass for inet/cidr.	10 years ago
inherit.sql	Handle OID column inheritance correctly in ALTER TABLE ... INHERIT.	9 years ago
init_privs.sql	GRANT rights to CURRENT_USER instead of adding roles	10 years ago
insert.sql	Set ecxt_scantuple correctly for tuple routing.	9 years ago
insert_conflict.sql	Band-aid fix for incorrect use of view options as StdRdOptions.	9 years ago
int2.sql	Add documentation and regression tests concerning rounding of numerics.	11 years ago
int4.sql	Add documentation and regression tests concerning rounding of numerics.	11 years ago
int8.sql	Add documentation and regression tests concerning rounding of numerics.	11 years ago
interval.sql	Fix interval_transform so it doesn't throw away non-no-op casts.	9 years ago
join.sql	Fix mishandling of equivalence-class tests in parameterized plans.	10 years ago
json.sql	Fix json_to_record() bug with nested objects.	10 years ago
json_encoding.sql	Fix whitespace	10 years ago
jsonb.sql	Implement array version of jsonb_delete and operator	9 years ago
limit.sql	Fix failure to mark all aggregates with appropriate transtype.	10 years ago
line.sql	Revert "Tweak "line" test to avoid negative zeros on some platforms"	12 years ago
lock.sql	Add a basic atomic ops API abstracting away platform/architecture details.	11 years ago
lseg.sql	…
macaddr.sql	Allow input format xxxx-xxxx-xxxx for macaddr type	11 years ago
matview.sql	Change unknown-type literals to type text in SELECT and RETURNING lists.	9 years ago
misc_functions.sql	Add num_nulls() and num_nonnulls() to count NULL arguments.	10 years ago
money.sql	Register missing money operators in system catalogs	9 years ago
name.sql	Introduce parse_ident()	10 years ago
namespace.sql	Regression tests for SCHEMA commands	12 years ago
numeric.sql	Speed up SUM calculation in numeric aggregates.	9 years ago
numeric_big.sql	Fix corner-case loss of precision in numeric pow() calculation	10 years ago
numerology.sql	…
object_address.sql	Establish conventions about global object names used in regression tests.	10 years ago
oid.sql	…
oidjoins.sql	Update oidjoins regression test for 9.6.	10 years ago
opr_sanity.sql	Fix type-safety problem with parallel aggregate serial/deserialization.	10 years ago
path.sql	…
pg_lsn.sql	Tweak new regression test case for better portability.	12 years ago
plancache.sql	Change plan caching to honor, not resist, changes in search_path.	13 years ago
plpgsql.sql	Fix handling of expanded objects in CoerceToDomain and CASE execution.	9 years ago
point.sql	Fix gist_box_same and gist_point_consistent to handle fuzziness correctly.	13 years ago
polygon.sql	regression tests: remove polygon diagrams	11 years ago
polymorphism.sql	Fix incorrect handling of polymorphic aggregates used as window functions.	9 years ago
portals.sql	Fix some interrelated planner issues with initPlans and Param munging.	10 years ago
portals_p2.sql	…
prepare.sql	…
prepared_xacts.sql	Eschew "RESET statement_timeout" in tests.	10 years ago
privileges.sql	Fix typos	10 years ago
psql.sql	Make regression tests less dependent on hash table order.	9 years ago
psql_crosstab.sql	Fix incorrect error reporting for duplicate data in \crosstabview.	9 years ago
publication.sql	Paper over pg_upgrade test failure	9 years ago
random.sql	…
rangefuncs.sql	Allow functions that return sets of tuples to return simple NULLs.	10 years ago
rangetypes.sql	Fix tqueue.c's range-remapping code.	10 years ago
regex.linux.utf8.sql	Make locale-dependent regex character classes work for large char codes.	9 years ago
regex.sql	Implement regexp_match(), a simplified alternative to regexp_matches().	10 years ago
regproc.sql	Establish conventions about global object names used in regression tests.	10 years ago
reltime.sql	…
replica_identity.sql	Fix possible crash in ALTER TABLE ... REPLICA IDENTITY USING INDEX.	10 years ago
returning.sql	Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.	11 years ago
roleattributes.sql	Establish conventions about global object names used in regression tests.	10 years ago
rolenames.sql	Establish conventions about global object names used in regression tests.	10 years ago
rowsecurity.sql	Add support for restrictive RLS policies	9 years ago
rowtypes.sql	Fix constant-folding of ROW(...) IS [NOT] NULL with composite fields.	10 years ago
rules.sql	Eliminate a few more user-visible "cache lookup failed" errors.	10 years ago
sanity_check.sql	Use unaligned output in selected regression queries to reduce diff noise.	12 years ago
security_label.sql	Establish conventions about global object names used in regression tests.	10 years ago
select.sql	Support using index-only scans with partial indexes in more cases.	10 years ago
select_distinct.sql	Disable physical tlist if any Var would need multiple sortgroupref labels.	10 years ago
select_distinct_on.sql	…
select_having.sql	…
select_implicit.sql	…
select_into.sql	Establish conventions about global object names used in regression tests.	10 years ago
select_parallel.sql	Run select_parallel test by itself	10 years ago
select_views.sql	Improve qual pushdown for RLS and SB views	11 years ago
sequence.sql	Add pg_sequence system catalog	9 years ago
spgist.sql	Add test cases for indexam operations not currently covered.	11 years ago
stats.sql	Make stats regression test robust in the face of parallel query.	10 years ago
strings.sql	Fix regexp_matches() handling of zero-length matches.	13 years ago
subscription.sql	Logical replication	9 years ago
subselect.sql	Change unknown-type literals to type text in SELECT and RETURNING lists.	9 years ago
tablesample.sql	Redesign tablesample method API, and do extensive code review.	11 years ago
temp.sql	…
text.sql	Move checking an explicit VARIADIC "any" argument into the parser.	13 years ago
time.sql	…
timestamp.sql	Be more careful about out-of-range dates and timestamps.	10 years ago
timestamptz.sql	Disable transforms that replaced AT TIME ZONE with RelabelType.	9 years ago
timetz.sql	…
tinterval.sql	…
transactions.sql	Fix subtransaction cleanup after an outer-subtransaction portal fails.	10 years ago
triggers.sql	Fix ON CONFLICT UPDATE bug breaking AFTER UPDATE triggers.	10 years ago
truncate.sql	…
tsdicts.sql	Phrase full text search.	10 years ago
tsearch.sql	Fix strange behavior (and possible crashes) in full text phrase search.	9 years ago
tsrf.sql	Fix platform dependant regression output triggered by 69f4b9c85f.	9 years ago
tstypes.sql	Fix strange behavior (and possible crashes) in full text phrase search.	9 years ago
txid.sql	Add txid_current_ifassigned().	10 years ago
type_sanity.sql	Add some checks on "char"-type columns to type_sanity and opr_sanity.	10 years ago
typed_table.sql	…
union.sql	Fix Assert failure induced by commit 215b43cdc.	9 years ago
updatable_views.sql	Use non-conflicting table names in new regression test case.	9 years ago
update.sql	Implement table partitioning.	9 years ago
uuid.sql	Fix whitespace issues found by git diff --check, add gitattributes	12 years ago
vacuum.sql	Add VACUUM (DISABLE_PAGE_SKIPPING) for emergencies.	10 years ago
varchar.sql	…
window.sql	Allow pushdown of WHERE quals into subqueries with window functions.	12 years ago
with.sql	Change unknown-type literals to type text in SELECT and RETURNING lists.	9 years ago
without_oid.sql	…
xml.sql	Remove xmlparse(document '') test	10 years ago
xmlmap.sql	Add regression tests for XML mapping of domains	13 years ago