You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 6a3d3965d6 Fix core dump in ReorderBufferRestoreChange on alignment-picky platforms. ... When re-reading an update involving both an old tuple and a new tuple from disk, reorderbuffer.c was careless about whether the new tuple is suitably aligned for direct access --- in general, it isn't. We'd missed seeing this in the buildfarm because the contrib/test_decoding tests exercise this code path only a few times, and by chance all of those cases have old tuples with length a multiple of 4, which is usually enough to make the access to the new tuple's t_len safe. For some still-not-entirely-clear reason, however, Debian's sparc build gets a bus error, as reported by Christoph Berg; perhaps it's assuming 8-byte alignment of the pointer? The lack of previous field reports is probably because you need all of these conditions to trigger a crash: an alignment-picky platform (not Intel), a transaction large enough to spill to disk, an update within that xact that changes a primary-key field and has an odd-length old tuple, and of course logical decoding tracing the transaction. Avoid the alignment assumption by using memcpy instead of fetching t_len directly, and add a test case that exposes the crash on picky platforms. Back-patch to 9.4 where the bug was introduced. Discussion: <20160413094117.GC21485@msg.credativ.de>		10 years ago
..
binary.out	Message style improvements	10 years ago
concurrent_ddl_dml.out	Add skip-empty-xacts option to test_decoding for use in the regression tests.	11 years ago
ddl.out	Fix core dump in ReorderBufferRestoreChange on alignment-picky platforms.	10 years ago
decoding_in_xact.out	Collection of typo fixes.	10 years ago
decoding_into_rel.out	Don't skip SQL backends in logical decoding for visibility computation.	11 years ago
delayed_startup.out	Introduce logical decoding.	12 years ago
messages.out	Add required database and origin filtering for logical messages.	10 years ago
mxact.out	Introduce logical decoding.	12 years ago
ondisk_startup.out	Fix several weaknesses in slot and logical replication on-disk serialization.	11 years ago
permissions.out	Add skip-empty-xacts option to test_decoding for use in the regression tests.	11 years ago
prepared.out	Add skip-empty-xacts option to test_decoding for use in the regression tests.	11 years ago
replorigin.out	Add required database and origin filtering for logical messages.	10 years ago
rewrite.out	Add skip-empty-xacts option to test_decoding for use in the regression tests.	11 years ago
time.out	logical decoding: fix decoding of a commit's commit time.	10 years ago
toast.out	logical decoding: Fix handling of large old tuples with replica identity full.	10 years ago
xact.out	logical decoding: Tell reorderbuffer about all xids.	10 years ago