You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 2425f8f714 Fix parallel pg_dump/pg_restore for failure to create worker processes. ... If we failed to fork a worker process, or create a communication pipe for one, WaitForTerminatingWorkers would suffer an assertion failure if assert-enabled, otherwise crash or go into an infinite loop. This was a consequence of not accounting for the startup condition where we've not yet forked all the workers. The original bug was that ParallelBackupStart would set workerStatus to WRKR_IDLE before it had successfully forked a worker. I made things worse in commit b7b8cc0cf by not understanding the undocumented fact that the WRKR_TERMINATED state was also meant to represent the case where a worker hadn't been started yet: I changed enum T_WorkerStatus so that *all* the worker slots were initially in WRKR_IDLE state. But this wasn't any more broken in practice, since even one slot in the wrong state would keep WaitForTerminatingWorkers from terminating. In v10 and later, introduce an explicit T_WorkerStatus value for worker-not-started, in hopes of preventing future oversights of the same ilk. Before that, just document that WRKR_TERMINATED is supposed to cover that case (partly because it wasn't actively broken, and partly because the enum is exposed outside parallel.c in those branches, so there's microscopically more risk involved in changing it). In all branches, introduce a WORKER_IS_RUNNING status test macro to hide which T_WorkerStatus values mean that, and be more careful not to access ParallelSlot fields till we're sure they're valid. Per report from Vignesh C, though this is my patch not his. Back-patch to all supported branches. Discussion: https://postgr.es/m/CALDaNm1Luv-E3sarR+-unz-BjchquHHyfP+YC+2FS2pt_J+wxg@mail.gmail.com		6 years ago
..
backend	Sprinkle some const decorations	6 years ago
bin	Fix parallel pg_dump/pg_restore for failure to create worker processes.	6 years ago
common	Move jsonapi.c and jsonapi.h to src/common.	6 years ago
fe_utils	Reduce size of backend scanner's tables.	6 years ago
include	Allow building without default socket directory	6 years ago
interfaces	Allow building without default socket directory	6 years ago
makefiles	Remove libpq.rc, use win32ver.rc for libpq	6 years ago
pl	Clean up newlines following left parentheses	6 years ago
port	Clean up newlines following left parentheses	6 years ago
template	…
test	Fix typo in recently-added TAP test for replication slots	6 years ago
timezone	…
tools	Fix vcregress.pl for new plperl test case.	6 years ago
tutorial	…
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Add support for automatically updating Unicode derived files	6 years ago
Makefile.shlib	…
nls-global.mk	…