You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Michael Paquier 7265dbffad Add TAP test to automate the equivalent of check_guc, take two ... src/backend/utils/misc/check_guc is a script that cross-checks the consistency of the GUCs with postgresql.conf.sample, making sure that its format is in line with what guc.c has. It has never been run automatically, and has rotten over the years, creating a lot of false positives as per a report from Justin Pryzby. d10e41d has introduced a SQL function to publish the most relevant flags associated to a GUC, with tests added in the main regression test suite to make sure that we avoid most of the inconsistencies in the GUC settings, based on recent reports, but there was nothing able to cross-check postgresql.conf.sample with the contents of guc.c. This commit adds a TAP test that covers the remaining gap. It emulates the most relevant checks that check_guc did, so as any format mistakes are detected in postgresql.conf.sample at development stage, with the following checks: - Check that parameters marked as NOT_IN_SAMPLE are not in the sample file. - Check that there are no dead entries in postgresql.conf.sample for parameters not marked as NOT_IN_SAMPLE. - Check that no parameters are missing from the sample file if listed in guc.c without NOT_IN_SAMPLE. The idea of building a list of the GUCs by parsing the sample file comes from Justin, and he wrote the regex used in the patch to find all the GUCs (this same formatting rule basically applies for the last 20~ years or so). In order to test this patch, I have played with manual modifications of postgresql.conf.sample and guc.c, making sure that we detect problems with the GUC rules and the sample file format. The test is located in src/test/modules/test_misc, which is the best location I could think about for such sanity checks, rather than the main regression test suite (src/test/regress) to avoid a new type of dependency with the source tree. The first attempt of this patch was b0a55f4, where the location of postgresql.conf.sample was retrieved using pg_config --sharedir. This has proven to be an issue for distributions that patch pg_config to enforce the installation paths at some wanted location (like Debian), that may not exist when the test is run, hence causing a failure. Instead of that, as per a suggestion from Andres Freund, rely on the fact that the test is always executed from its directory in the source tree and use a relative path to find the sample file. This works for the CI, VPATH builds and on Windows, and tests like the recovery one added in f47ed79 rely on that already. Reviewed-by: Justin Pryzby Discussion: https://postgr.es/m/Yf9YGSwPiMu0c7fP@paquier.xyz		4 years ago
..
backend	Update "don't truncate with failsafe" rationale.	4 years ago
bin	Remove command checks in tests of pg_basebackup and pg_receivewal	4 years ago
common	Suppress integer-overflow compiler warning for inconsistent sun_len.	4 years ago
fe_utils	Avoid calling gettext() in signal handlers.	4 years ago
include	Remove IS_AF_UNIX macro	4 years ago
interfaces	Remove IS_AF_UNIX macro	4 years ago
makefiles	…
pl	Use gendef instead of pexports for building windows .def files	4 years ago
port	Simplify coding around path_contains_parent_reference().	4 years ago
template	…
test	Add TAP test to automate the equivalent of check_guc, take two	4 years ago
timezone	Update copyright for 2022	4 years ago
tools	Remove REGRESS_OUTPUTDIR environment variable.	4 years ago
tutorial	Update copyright for 2022	4 years ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Add ./configure check for "lz4" command	4 years ago
Makefile.shlib	AIX: Fix missing libpq symbols by respecting SHLIB_EXPORTS.	4 years ago
nls-global.mk	…