You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 2a600a93c7 Make type Datum be 8 bytes wide everywhere. ... This patch makes sizeof(Datum) be 8 on all platforms including 32-bit ones. The objective is to allow USE_FLOAT8_BYVAL to be true everywhere, and in consequence to remove a lot of code that is specific to pass-by-reference handling of float8, int8, etc. The code for abbreviated sort keys can be simplified similarly. In this way we can reduce the maintenance effort involved in supporting 32-bit platforms, without going so far as to actually desupport them. Since Datum is strictly an in-memory concept, this has no impact on on-disk storage, though an initdb or pg_upgrade will be needed to fix affected catalog entries. We have required platforms to support [u]int64 for ages, so this breaks no supported platform. We can expect that this change will make 32-bit builds a bit slower and more memory-hungry, although being able to use pass-by-value handling of 8-byte types may buy back some of that. But we stopped optimizing for 32-bit cases a long time ago, and this seems like just another step on that path. This initial patch simply forces the correct type definition and USE_FLOAT8_BYVAL setting, and cleans up a couple of minor compiler complaints that ensued. This is sufficient for testing purposes. In the wake of a bunch of Datum-conversion cleanups by Peter Eisentraut, this now compiles cleanly with gcc on a 32-bit platform. (I'd only tested the previous version with clang, which it turns out is less picky than gcc about width-changing coercions.) There is a good deal of now-dead code that I'll remove in separate follow-up patches. A catversion bump is required because this affects initial catalog contents (on 32-bit machines) in two ways: pg_type.typbyval changes for some built-in types, and Const nodes in stored views/rules will now have 8 bytes not 4 for pass-by-value types. Author: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Peter Eisentraut <peter@eisentraut.org> Discussion: https://postgr.es/m/1749799.1752797397@sss.pgh.pa.us		10 months ago
..
aio	Fix rare bug in read_stream.c's split IO handling.	10 months ago
buffer	Add missing Datum conversions	10 months ago
file	Fix various hash function uses	10 months ago
freespace	doc: Correct description of values used in FSM for indexes	1 year ago
ipc	Make type Datum be 8 bytes wide everywhere.	10 months ago
large_object	Suppress maybe-uninitialized warning.	10 months ago
lmgr	Add missing Datum conversions	10 months ago
page	Fix typos and grammar in the code	1 year ago
smgr	Harmonize function parameter names for Postgres 18.	1 year ago
sync	Update copyright for 2025	1 year ago
Makefile	Provide API for streaming relation data.	2 years ago
meson.build	Update copyright for 2025	1 year ago