You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 5028981923 Fix handling of CREATE TABLE LIKE with inheritance. ... If a CREATE TABLE command uses both LIKE and traditional inheritance, Vars in CHECK constraints and expression indexes that are absorbed from a LIKE parent table tended to get mis-numbered, resulting in wrong answers and/or bizarre error messages (though probably not any actual crashes, thanks to validation occurring in the executor). In v12 and up, the same could happen to Vars in GENERATED expressions, even in cases with no LIKE clause but multiple traditional-inheritance parents. The cause of the problem for LIKE is that parse_utilcmd.c supposed it could renumber such Vars correctly during transformCreateStmt(), which it cannot since we have not yet accounted for columns added via inheritance. Fix that by postponing processing of LIKE INCLUDING CONSTRAINTS, DEFAULTS, GENERATED, INDEXES till after we've performed DefineRelation(). The error with GENERATED and multiple inheritance is a simple oversight in MergeAttributes(); it knows it has to renumber Vars in inherited CHECK constraints, but forgot to apply the same processing to inherited GENERATED expressions (a/k/a defaults). Per bug #16272 from Tom Gottfried. The non-GENERATED variants of the issue are ancient, presumably dating right back to the addition of CREATE TABLE LIKE; hence back-patch to all supported branches. Discussion: https://postgr.es/m/16272-6e32da020e9a9381@postgresql.org		5 years ago
..
backend	Fix handling of CREATE TABLE LIKE with inheritance.	5 years ago
bin	Avoid non-constant format string argument to fprintf().	5 years ago
common	Replace remaining StrNCpy() by strlcpy()	5 years ago
fe_utils	Move connect.h from fe_utils to src/include/common.	5 years ago
include	Fix handling of CREATE TABLE LIKE with inheritance.	5 years ago
interfaces	Replace remaining StrNCpy() by strlcpy()	5 years ago
makefiles	Remove libpq.rc, use win32ver.rc for libpq	6 years ago
pl	Fix -Wcast-function-type warnings	5 years ago
port	Remove optimization for RAND_poll() failing.	5 years ago
template	Fix compiler warning for ppoll() on Cygwin	6 years ago
test	Fix handling of CREATE TABLE LIKE with inheritance.	5 years ago
timezone	Ensure that distributed timezone abbreviation files are plain ASCII.	5 years ago
tools	snapshot scalability: Move subxact info to ProcGlobal, remove PGXACT.	5 years ago
tutorial	Update copyrights for 2020	6 years ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Update Unicode data to Unicode 13.0.0 and CLDR 37	5 years ago
Makefile.shlib	Add PostgreSQL home page to --help output	6 years ago
nls-global.mk	…