You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

David Rowley 2c7887c9d6 Fix Assert failure in WITH RECURSIVE UNION queries ... If the non-recursive part of a recursive CTE ended up using TTSOpsBufferHeapTuple as the table slot type, then a duplicate value could cause an Assert failure in CheckOpSlotCompatibility() when checking the hash table for the duplicate value. The expected slot type for the deform step was TTSOpsMinimalTuple so the Assert failed when the TTSOpsBufferHeapTuple slot was used. This is a long-standing bug which we likely didn't notice because it seems much more likely that the non-recursive term would have required projection and used a TTSOpsVirtual slot, which CheckOpSlotCompatibility is ok with. There doesn't seem to be any harm done here other than the Assert failure. Both TTSOpsMinimalTuple and TTSOpsBufferHeapTuple slot types require tuple deformation, so the EEOP_*_FETCHSOME ExprState step would have properly existed in the ExprState. The solution is to pass NULL for the ExecBuildGroupingEqual's 'lops' parameter. This means the ExprState's EEOP_*_FETCHSOME step won't expect a fixed slot type. This makes CheckOpSlotCompatibility() happy as no checking is performed when the ExprEvalStep is not expecting a fixed slot type. Reported-by: Richard Guo Reviewed-by: Tom Lane Discussion: https://postgr.es/m/CAMbWs4-8U9q2LAtf8+ghV11zeUReA3AmrYkxzBEv0vKnDxwkKA@mail.gmail.com Backpatch-through: 13, all supported versions		9 months ago
..
access	Revert "Handle better implicit transaction state of pipeline mode"	10 months ago
bootstrap	Skip WAL for new relfilenodes, under wal_level=minimal.	6 years ago
catalog	Make getObjectDescription robust against dangling amproc type links.	9 months ago
commands	Ensure that pg_amop/amproc entries depend on their lefttype/righttype.	9 months ago
executor	Fix Assert failure in WITH RECURSIVE UNION queries	9 months ago
foreign	Restrict accesses to non-system views and foreign tables during pg_dump.	1 year ago
jit	Fix NULLIF()'s handling of read-write expanded objects.	10 months ago
lib	Accommodate very large dshash tables.	9 months ago
libpq	Fix regression in TLS session ticket disabling	1 year ago
main	Fix elog(FATAL) before PostmasterMain() or just after fork().	9 months ago
nodes	Further fixes for MULTIEXPR_SUBLINK fix.	3 years ago
optimizer	Compare collations before merging UNION operations.	10 months ago
parser	Remove incorrect Assert.	1 year ago
partitioning	Fix creation of partition descriptor during concurrent detach+drop	1 year ago
po	Translation updates	10 months ago
port	Check for STATUS_DELETE_PENDING on Windows.	10 months ago
postmaster	Fix elog(FATAL) before PostmasterMain() or just after fork().	9 months ago
regex	Fix recently-exposed portability issue in regex optimization.	10 months ago
replication	Fix unused-but-set-variable compiler warning in reorderbuffer.c.	9 months ago
rewrite	Ensure cached plans are correctly marked as dependent on role.	10 months ago
snowball	In the Snowball dictionary, don't try to stem excessively-long words.	3 years ago
statistics	Fix incorrectly reported stats kind in "can't happen" ERROR	2 years ago
storage	At end of recovery, reset all sinval-managed caches.	11 months ago
tcop	Simplify executor's determination of whether to use parallelism.	9 months ago
tsearch	Limit to_tsvector_byid's initial array allocation to something sane.	2 years ago
utils	Fix is_digit labeling of to_timestamp's FFn format codes.	9 months ago
.gitignore	…
Makefile	Update copyrights for 2020	6 years ago
common.mk	…
nls.mk	Translation updates	5 years ago