You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Dean Rasheed 2d5b97b8c6 Avoid rewriting data-modifying CTEs more than once. ... Formerly, when updating an auto-updatable view, or a relation with rules, if the original query had any data-modifying CTEs, the rewriter would rewrite those CTEs multiple times as RewriteQuery() recursed into the product queries. In most cases that was harmless, because RewriteQuery() is mostly idempotent. However, if the CTE involved updating an always-generated column, it would trigger an error because any subsequent rewrite would appear to be attempting to assign a non-default value to the always-generated column. This could perhaps be fixed by attempting to make RewriteQuery() fully idempotent, but that looks quite tricky to achieve, and would probably be quite fragile, given that more generated-column-type features might be added in the future. Instead, fix by arranging for RewriteQuery() to rewrite each CTE exactly once (by tracking the number of CTEs already rewritten as it recurses). This has the advantage of being simpler and more efficient, but it does make RewriteQuery() dependent on the order in which rewriteRuleAction() joins the CTE lists from the original query and the rule action, so care must be taken if that is ever changed. Reported-by: Bernice Southey <bernice.southey@gmail.com> Author: Bernice Southey <bernice.southey@gmail.com> Author: Dean Rasheed <dean.a.rasheed@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: Kirill Reshke <reshkekirill@gmail.com> Discussion: https://postgr.es/m/CAEDh4nyD6MSH9bROhsOsuTqGAv_QceU_GDvN9WcHLtZTCYM1kA@mail.gmail.com Backpatch-through: 14		3 weeks ago
..
backend	Avoid rewriting data-modifying CTEs more than once.	3 weeks ago
bin	Print new OldestXID value in pg_resetwal when it's being changed	4 weeks ago
common	With GB18030, prevent SIGSEGV from reading past end of allocation.	8 months ago
fe_utils	In fmtIdEnc(), handle failure of enlargePQExpBuffer().	10 months ago
include	Fix incorrect IndexOptInfo header comment	3 weeks ago
interfaces	libpq: Prevent some overflows of int/size_t	1 month ago
makefiles	…
pl	Translation updates	1 month ago
port	Fix POSIX compliance in pgwin32_unsetenv() for "name" argument	2 months ago
template	On NetBSD, force dynamic symbol resolution at postmaster start.	3 years ago
test	Avoid rewriting data-modifying CTEs more than once.	3 weeks ago
timezone	Update time zone data files to tzdata release 2025b.	8 months ago
tools	Fix MSVC pg_upgrade test.	4 months ago
tutorial	Doc: sync src/tutorial/basics.source with SGML documentation.	3 years ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Don't put library-supplied -L/-I switches before user-supplied ones.	5 months ago
Makefile.shlib	Stop using "-multiply_defined suppress" on macOS.	2 years ago
nls-global.mk	Fix update-po for the PGXS case	2 months ago