You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Peter Geoghegan 3fa81b62e0 Fix btmarkpos/btrestrpos array key wraparound bug. ... nbtree's mark/restore processing failed to correctly handle an edge case involving array key advancement and related search-type scan key state. Scans with ScalarArrayScalarArrayOpExpr quals requiring mark/restore processing (for a merge join) could incorrectly conclude that an affected array/scan key must not have advanced during the time between marking and restoring the scan's position. As a result of all this, array key handling within btrestrpos could skip a required call to _bt_preprocess_keys(). This confusion allowed later primitive index scans to overlook tuples matching the true current array keys. The scan's search-type scan keys would still have spurious values corresponding to the final array element(s) -- not values matching the first/now-current array element(s). To fix, remember that "array key wraparound" has taken place during the ongoing btrescan in a flag variable stored in the scan's state, and use that information at the point where btrestrpos decides if another call to _bt_preprocess_keys is required. Oversight in commit 70bc5833, which taught nbtree to handle array keys during mark/restore processing, but missed this subtlety. That commit was itself a bug fix for an issue in commit 9e8da0f7, which taught nbtree to handle ScalarArrayOpExpr quals natively. Author: Peter Geoghegan <pg@bowt.ie> Discussion: https://postgr.es/m/CAH2-WzkgP3DDRJxw6DgjCxo-cu-DKrvjEv_ArkP2ctBJatDCYg@mail.gmail.com Backpatch: 11- (all supported branches).		2 years ago
..
backend	Fix btmarkpos/btrestrpos array key wraparound bug.	2 years ago
bin	pg_dump: tests: Correct test condition for invalid databases	2 years ago
common	meson: Add dependencies to perl modules to various script invocations	2 years ago
fe_utils	Pre-beta mechanical code beautification.	2 years ago
include	Fix btmarkpos/btrestrpos array key wraparound bug.	2 years ago
interfaces	Translation updates	2 years ago
makefiles	Use --strip-unneeded when stripping static libraries with GNU strip.	2 years ago
pl	Collect dependency information for parsed CallStmts.	2 years ago
port	Meson: check for pg_config_paths.h left over from make	2 years ago
template	…
test	Fix edge-case for xl_tot_len broken by bae868ca.	2 years ago
timezone	Pre-beta mechanical code beautification.	2 years ago
tools	Fix exception safety bug in typcache.c.	2 years ago
tutorial	Pre-beta mechanical code beautification.	2 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Integrate pg_bsd_indent into our build/test infrastructure.	3 years ago
Makefile.global.in	Fix prove_installcheck when used with PGXS	2 years ago
Makefile.shlib	Stop using "-multiply_defined suppress" on macOS.	2 years ago
meson.build	Integrate pg_bsd_indent into our build/test infrastructure.	3 years ago
nls-global.mk	…