You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane b8a1247a34 Fix INSERT ON CONFLICT UPDATE through a view that isn't just SELECT *. ... When expanding an updatable view that is an INSERT's target, the rewriter failed to rewrite Vars in the ON CONFLICT UPDATE clause. This accidentally worked if the view was just "SELECT * FROM ...", as the transformation would be a no-op in that case. With more complicated view targetlists, this omission would often lead to "attribute ... has the wrong type" errors or even crashes, as reported by Mario De Frutos Dieguez. Fix by adding code to rewriteTargetView to fix up the data structure correctly. The easiest way to update the exclRelTlist list is to rebuild it from scratch looking at the new target relation, so factor the code for that out of transformOnConflictClause to make it sharable. In passing, avoid duplicate permissions checks against the EXCLUDED pseudo-relation, and prevent useless view expansion of that relation's dummy RTE. The latter is only known to happen (after this patch) in cases where the query would fail later due to not having any INSTEAD OF triggers for the view. But by exactly that token, it would create an unintended and very poorly tested state of the query data structure, so it seems like a good idea to prevent it from happening at all. This has been broken since ON CONFLICT was introduced, so back-patch to 9.5. Dean Rasheed, based on an earlier patch by Amit Langote; comment-kibitzing and back-patching by me Discussion: https://postgr.es/m/CAFYwGJ0xfzy8jaK80hVN2eUWr6huce0RU8AgU04MGD00igqkTg@mail.gmail.com		8 years ago
..
.gitignore	Convert cvsignore to gitignore, and add .gitignore for build targets.	15 years ago
analyze.h	Fix INSERT ON CONFLICT UPDATE through a view that isn't just SELECT *.	8 years ago
gramparse.h	Update copyright for 2018	8 years ago
kwlist.h	Revert MERGE patch	8 years ago
parse_agg.h	Update copyright for 2018	8 years ago
parse_clause.h	Revert MERGE patch	8 years ago
parse_coerce.h	Update copyright for 2018	8 years ago
parse_collate.h	Update copyright for 2018	8 years ago
parse_cte.h	Update copyright for 2018	8 years ago
parse_enr.h	Update copyright for 2018	8 years ago
parse_expr.h	Update copyright for 2018	8 years ago
parse_func.h	Post-feature-freeze pgindent run.	8 years ago
parse_node.h	Revert MERGE patch	8 years ago
parse_oper.h	Update copyright for 2018	8 years ago
parse_param.h	Update copyright for 2018	8 years ago
parse_relation.h	Update copyright for 2018	8 years ago
parse_target.h	Update copyright for 2018	8 years ago
parse_type.h	Update copyright for 2018	8 years ago
parse_utilcmd.h	Allow UNIQUE indexes on partitioned tables	8 years ago
parser.h	Update copyright for 2018	8 years ago
parsetree.h	Update copyright for 2018	8 years ago
scanner.h	Update copyright for 2018	8 years ago
scansup.h	Update copyright for 2018	8 years ago