You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 72697d2ba7 Fix incorrect order of lock file removal and failure to close() sockets. ... Commit c9b0cbe98b accidentally broke the order of operations during postmaster shutdown: it resulted in removing the per-socket lockfiles after, not before, postmaster.pid. This creates a race-condition hazard for a new postmaster that's started immediately after observing that postmaster.pid has disappeared; if it sees the socket lockfile still present, it will quite properly refuse to start. This error appears to be the explanation for at least some of the intermittent buildfarm failures we've seen in the pg_upgrade test. Another problem, which has been there all along, is that the postmaster has never bothered to close() its listen sockets, but has just allowed them to close at process death. This creates a different race condition for an incoming postmaster: it might be unable to bind to the desired listen address because the old postmaster is still incumbent. This might explain some odd failures we've seen in the past, too. (Note: this is not related to the fact that individual backends don't close their client communication sockets. That behavior is intentional and is not changed by this patch.) Fix by adding an on_proc_exit function that closes the postmaster's ports explicitly, and (in 9.3 and up) reshuffling the responsibility for where to unlink the Unix socket files. Lock file unlinking can stay where it is, but teach it to unlink the lock files in reverse order of creation.		11 years ago
..
Makefile	Allow background workers to be started dynamically.	13 years ago
autovacuum.c	Fix thinko in comment (launcher -> worker)	11 years ago
bgworker.c	Reduce log level for background worker events from LOG to DEBUG1.	11 years ago
bgwriter.c	Fix more typos in comments.	11 years ago
checkpointer.c	Also trigger restartpoints based on max_wal_size on standby.	11 years ago
fork_process.c	Update copyright for 2015	11 years ago
pgarch.c	Tweak __attribute__-wrapping macros for better pgindent results.	11 years ago
pgstat.c	Further code review for pg_stat_ssl patch.	11 years ago
postmaster.c	Fix incorrect order of lock file removal and failure to close() sockets.	11 years ago
startup.c	Commonalize process startup code.	11 years ago
syslogger.c	Tweak __attribute__-wrapping macros for better pgindent results.	11 years ago
walwriter.c	Add a default local latch for use in signal handlers.	11 years ago