You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 34ea1ab7fd Split create_foreignscan_path() into three functions. ... Up to now postgres_fdw has been using create_foreignscan_path() to generate not only base-relation paths, but also paths for foreign joins and foreign upperrels. This is wrong, because create_foreignscan_path() calls get_baserel_parampathinfo() which will only do the right thing for baserels. It accidentally fails to fail for unparameterized paths, which are the only ones postgres_fdw (thought it) was handling, but we really need different APIs for the baserel and join cases. In HEAD, the best thing to do seems to be to split up the baserel, joinrel, and upperrel cases into three functions so that they can have different APIs. I haven't actually given create_foreign_join_path a different API in this commit: we should spend a bit of time thinking about just what we want to do there, since perhaps FDWs would want to do something different from the build-up-a-join-pairwise approach that get_joinrel_parampathinfo expects. In the meantime, since postgres_fdw isn't prepared to generate parameterized joins anyway, just give it a defense against trying to plan joins with lateral refs. In addition (and this is what triggered this whole mess) fix bug #15613 from Srinivasan S A, by teaching file_fdw and postgres_fdw that plain baserel foreign paths still have outer refs if the relation has lateral_relids. Add some assertions in relnode.c to catch future occurrences of the same error --- in particular, to catch other FDWs doing that, but also as backstop against core-code mistakes like the one fixed by commit bdd9a99aa. Bug #15613 also needs to be fixed in the back branches, but the appropriate fix will look quite a bit different there, since we don't want to assume that existing FDWs get the word right away. Discussion: https://postgr.es/m/15613-092be1be9576c728@postgresql.org		7 years ago
..
backend	Split create_foreignscan_path() into three functions.	7 years ago
bin	Fix searchpath and module location for pg_rewind and ssl TAP tests	7 years ago
common	Use perfect hashing, instead of binary search, for keyword lookup.	7 years ago
fe_utils	pgbench: add \cset and \gset commands	7 years ago
include	Split create_foreignscan_path() into three functions.	7 years ago
interfaces	Change error handling of out of scope variables in ecpg.	7 years ago
makefiles	Move port-specific parts of with_temp_install to port makefile.	7 years ago
pl	Renaming for new subscripting mechanism	7 years ago
port	Use our own getopt() on OpenBSD.	7 years ago
template	Yet further rethinking of build changes for macOS Mojave.	7 years ago
test	Fix searchpath and module location for pg_rewind and ssl TAP tests	7 years ago
timezone	Update time zone data files to tzdata release 2018i.	7 years ago
tools	Fix perl searchpath for gen_keywordlist.pl	7 years ago
tutorial	SQL comment: remove extra word in heading comment	7 years ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Move port-specific parts of with_temp_install to port makefile.	7 years ago
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	7 years ago
nls-global.mk	Replace @postgresql.org with @lists.postgresql.org for mailinglists	7 years ago