You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Heikki Linnakangas 22251686f0 Detect internal GiST page splits correctly during index build. ... As we descend the GiST tree during insertion, we modify any downlinks on the way down to include the new tuple we're about to insert (if they don't cover it already). Modifying an existing downlink might cause an internal page to split, if the new downlink tuple is larger than the old one. If that happens, we need to back up to the parent and re-choose a page to insert to. We used to detect that situation, thanks to the NSN-LSN interlock normally used to detect concurrent page splits, but that got broken by commit 9155580fd5. With that commit, we now use a dummy constant LSN value for every page during index build, so the LSN-NSN interlock no longer works. I thought that was OK because there can't be any other backends modifying the index during index build, but missed that the insertion itself can modify the page we're inserting to. The consequence was that we would sometimes insert the new tuple to an incorrect page, one whose downlink doesn't cover the new tuple. To fix, add a flag to the stack that keeps track of the state while descending tree, to indicate that a page was split, and that we need to retry the descend from the parent. Thomas Munro first reported that the contrib/intarray regression test was failing occasionally on the buildfarm after commit 9155580fd5. The failure was intermittent, because the gistchoose() function is not deterministic, and would only occasionally create the right circumstances for this bug to cause the failure. Patch by Anastasia Lubennikova, with some changes by me to make it work correctly also when the internal page split also causes the "grandparent" to be split. Discussion: https://www.postgresql.org/message-id/CA%2BhUKGJRzLo7tZExWfSbwM3XuK7aAK7FhdBV0FLkbUG%2BW0v0zg%40mail.gmail.com		7 years ago
..
backend	Detect internal GiST page splits correctly during index build.	7 years ago
bin	Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.	7 years ago
common	Fix function names in comments.	7 years ago
fe_utils	Ensure consistent name matching behavior in processSQLNamePattern().	7 years ago
include	Detect internal GiST page splits correctly during index build.	7 years ago
interfaces	Fix misuse of an integer as a bool.	7 years ago
makefiles	Define WIN32_STACK_RLIMIT throughout win32 and cygwin builds.	7 years ago
pl	Fix grammar in error message	7 years ago
port	Assert that pgwin32_signal_initialize() has been called early enough.	7 years ago
template	Yet further rethinking of build changes for macOS Mojave.	7 years ago
test	Fix misoptimization of "{1,1}" quantifiers in regular expressions.	7 years ago
timezone	Portability fix for zic.c.	7 years ago
tools	MSVC: Build ~35% faster by calling dumpbin just once per directory.	7 years ago
tutorial	SQL comment: remove extra word in heading comment	7 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Fix partial-build problems introduced by having more generated headers.	8 years ago
Makefile.global.in	Consistently test for in-use shared memory.	7 years ago
Makefile.shlib	Ensure static libraries have correct mod time even if ranlib messes it up.	7 years ago
nls-global.mk	Unified logging system for command-line programs	7 years ago