You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 3b0776fde5 Compute aggregate argument types correctly in transformAggregateCall(). ... transformAggregateCall() captures the datatypes of the aggregate's arguments immediately to construct the Aggref.aggargtypes list. This seems reasonable because the arguments have already been transformed --- but there is an edge case where they haven't been. Specifically, if we have an unknown-type literal in an ANY argument position, nothing will have been done with it earlier. But if we also have DISTINCT, then addTargetToGroupList() converts the literal to "text" type, resulting in the aggargtypes list not matching the actual runtime type of the argument. The end result is that the aggregate tries to interpret a "text" value as being of type "unknown", that is a zero-terminated C string. If the text value contains no zero bytes, this could result in disclosure of server memory following the text literal value. To fix, move the collection of the aggargtypes list to the end of transformAggregateCall(), after DISTINCT has been handled. This requires slightly more code, but not a great deal. Our thanks to Jingzhou Fu for reporting this problem. Security: CVE-2023-5868		2 years ago
..
backend	Compute aggregate argument types correctly in transformAggregateCall().	2 years ago
bin	Remove distprep	2 years ago
common	Remove distprep	2 years ago
fe_utils	Remove distprep	2 years ago
include	Remove distprep	2 years ago
interfaces	Remove distprep	2 years ago
makefiles	Remove distprep	2 years ago
pl	Remove distprep	2 years ago
port	Remove distprep	2 years ago
template	…
test	Compute aggregate argument types correctly in transformAggregateCall().	2 years ago
timezone	Remove distprep	2 years ago
tools	Remove distprep	2 years ago
tutorial	Pre-beta mechanical code beautification.	2 years ago
.gitignore	…
DEVELOPERS	…
Makefile	Remove distprep	2 years ago
Makefile.global.in	Remove distprep	2 years ago
Makefile.shlib	Stop using "-multiply_defined suppress" on macOS.	2 years ago
meson.build	Integrate pg_bsd_indent into our build/test infrastructure.	3 years ago
nls-global.mk	Remove distprep	2 years ago