You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Michael Paquier 35a428f30b pg_stat_statements: Fix parameter number gaps in normalized queries ... pg_stat_statements anticipates that certain constant locations may be recorded multiple times and attempts to avoid calculating a length for these locations in fill_in_constant_lengths(). However, during generate_normalized_query() where normalized query strings are generated, these locations are not excluded from consideration. This could increment the parameter number counter for every recorded occurrence at such a location, leading to an incorrect normalization in certain cases with gaps in the numbers reported. For example, take this query: SELECT WHERE '1' IN ('2'::int, '3'::int::text) Before this commit, it would be normalized like that, with gaps in the parameter numbers: SELECT WHERE $1 IN ($3::int, $4::int::text) However the correct, less confusing one should be like that: SELECT WHERE $1 IN ($2::int, $3::int::text) This commit fixes the computation of the parameter numbers to track the number of constants replaced with an $n by a separate counter instead of the iterator used to loop through the list of locations. The underlying query IDs are not changed, neither are the normalized strings for existing PGSS hash entries. New entries with fresh normalized queries would automatically get reshaped based on the new parameter numbering. Issue discovered while discussing a separate problem for HEAD, but this affects all the stable branches. Author: Sami Imseih <samimseih@gmail.com> Discussion: https://postgr.es/m/CAA5RZ0tzxvWXsacGyxrixdhy3tTTDfJQqxyFBRFh31nNHBQ5qA@mail.gmail.com Backpatch-through: 13		1 month ago
..
cleanup.out	Refactor tests of pg_stat_statements for planning, utility and level tracking	2 years ago
cursors.out	Add NOT NULL checking of pg_stat_statements_reset() in tests	2 years ago
dml.out	Remove the query_id_squash_values GUC	3 months ago
entry_timestamp.out	Track statement entry timestamp in contrib/pg_stat_statements	2 years ago
extended.out	pg_stat_statements: Fix parameter number gaps in normalized queries	1 month ago
level_tracking.out	Fix regression with location calculation of nested statements	1 month ago
oldextversions.out	pg_stat_statements: Add wal_buffers_full	4 months ago
parallel.out	pg_stat_statements: Add columns to track parallel worker activity	9 months ago
planning.out	Track more precisely query locations for nested statements	8 months ago
privileges.out	pg_stat_statements: Add regression test for privilege handling.	11 months ago
select.out	pg_stat_statements: Fix parameter number gaps in normalized queries	1 month ago
squashing.out	Remove the query_id_squash_values GUC	3 months ago
user_activity.out	Add NOT NULL checking of pg_stat_statements_reset() in tests	2 years ago
utility.out	Track more precisely query locations for nested statements	8 months ago
wal.out	Show values of SET statements as constants in pg_stat_statements	9 months ago