postgres

History

Tom Lane 0986e95161 Revise APIs for pushJsonbValue() and associated routines. Instead of passing "JsonbParseState **" to pushJsonbValue(), pass a pointer to a JsonbInState, which will contain the parseState stack pointer as well as other useful fields. Also, instead of returning a JsonbValue pointer that is often meaningless/ignored, return the top-level JsonbValue pointer in the "result" field of the JsonbInState. This involves a lot of (mostly mechanical) edits, but I think the results are notationally cleaner and easier to understand. Certainly the business with sometimes capturing the result of pushJsonbValue() and sometimes not was bug-prone and incapable of mechanical verification. In the new arrangement, JsonbInState.result remains null until we've completed a valid sequence of pushes, so that an incorrect sequence will result in a null-pointer dereference, not mistaken use of a partial result. However, this isn't simply an exercise in prettier notation. The real reason for doing it is to provide a mechanism whereby pushJsonbValue() can be told to construct the JsonbValue tree in a context that is not CurrentMemoryContext. That happens when a non-null "outcontext" is specified in the JsonbInState. No callers exercise that option in this patch, but the next patch in the series will make use of it. I tried to improve the comments in this area too. Author: Tom Lane <tgl@sss.pgh.pa.us> Reviewed-by: jian he <jian.universality@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Discussion: https://postgr.es/m/1060917.1753202222@sss.pgh.pa.us		3 weeks ago
..
data	…
expected	…
sql	…
.gitignore	…
Makefile	…
hstore--1.1--1.2.sql	…
hstore--1.2--1.3.sql	…
hstore--1.3--1.4.sql	…
hstore--1.4--1.5.sql	…
hstore--1.4.sql	…
hstore--1.5--1.6.sql	…
hstore--1.6--1.7.sql	…
hstore--1.7--1.8.sql	…
hstore.control	…
hstore.h	…
hstore_compat.c	…
hstore_gin.c	Fix varatt versus Datum type confusions	5 months ago
hstore_gist.c	Use more palloc_object() and palloc_array() in contrib/	3 weeks ago
hstore_io.c	Revise APIs for pushJsonbValue() and associated routines.	3 weeks ago
hstore_op.c	Fix varatt versus Datum type confusions	5 months ago
hstore_subs.c	Fix stray references to SubscriptRef	3 weeks ago
meson.build	Update copyright for 2025	12 months ago