You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane d0cfc3d6a4 Add a debugging option to stress-test outfuncs.c and readfuncs.c. ... In the normal course of operation, query trees will be serialized only if they are stored as views or rules; and plan trees will be serialized only if they get passed to parallel-query workers. This leaves an awful lot of opportunity for bugs/oversights to not get detected, as indeed we've just been reminded of the hard way. To improve matters, this patch adds a new compile option WRITE_READ_PARSE_PLAN_TREES, which is modeled on the longstanding option COPY_PARSE_PLAN_TREES; but instead of passing all parse and plan trees through copyObject, it passes them through nodeToString + stringToNode. Enabling this option in a buildfarm animal or two will catch problems at least for cases that are exercised by the regression tests. A small problem with this idea is that readfuncs.c historically has discarded location fields, on the reasonable grounds that parse locations in a retrieved view are not relevant to the current query. But doing that in WRITE_READ_PARSE_PLAN_TREES breaks pg_stat_statements, and it could cause problems for future improvements that might try to report error locations at runtime. To fix that, provide a variant behavior in readfuncs.c that makes it restore location fields when told to. In passing, const-ify the string arguments of stringToNode and its subsidiary functions, just because it annoyed me that they weren't const already. Discussion: https://postgr.es/m/17114.1537138992@sss.pgh.pa.us		7 years ago
..
bitmapset.h	Add bms_prev_member function	8 years ago
execnodes.h	Fix parsetree representation of XMLTABLE(XMLNAMESPACES(DEFAULT ...)).	7 years ago
extensible.h	Update copyright for 2018	8 years ago
lockoptions.h	Update copyright for 2018	8 years ago
makefuncs.h	Update copyright for 2018	8 years ago
memnodes.h	Allow memory contexts to have both fixed and variable ident strings.	8 years ago
nodeFuncs.h	Update copyright for 2018	8 years ago
nodes.h	Add a debugging option to stress-test outfuncs.c and readfuncs.c.	7 years ago
params.h	Update copyright for 2018	8 years ago
parsenodes.h	Fix some minor issues exposed by outfuncs/readfuncs testing.	7 years ago
pg_list.h	Update copyright for 2018	8 years ago
plannodes.h	Fix run-time partition pruning for appends with multiple source rels.	8 years ago
primnodes.h	Fix parsetree representation of XMLTABLE(XMLNAMESPACES(DEFAULT ...)).	7 years ago
print.h	Update copyright for 2018	8 years ago
readfuncs.h	Add a debugging option to stress-test outfuncs.c and readfuncs.c.	7 years ago
relation.h	Disable support for partitionwise joins in problematic cases.	7 years ago
replnodes.h	Update copyright for 2018	8 years ago
tidbitmap.h	Update copyright for 2018	8 years ago
value.h	Change internal integer representation of Value node	8 years ago