You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Alvaro Herrera ff9f111bce Fix WAL replay in presence of an incomplete record ... Physical replication always ships WAL segment files to replicas once they are complete. This is a problem if one WAL record is split across a segment boundary and the primary server crashes before writing down the segment with the next portion of the WAL record: WAL writing after crash recovery would happily resume at the point where the broken record started, overwriting that record ... but any standby or backup may have already received a copy of that segment, and they are not rewinding. This causes standbys to stop following the primary after the latter crashes: LOG: invalid contrecord length 7262 at A8/D9FFFBC8 because the standby is still trying to read the continuation record (contrecord) for the original long WAL record, but it is not there and it will never be. A workaround is to stop the replica, delete the WAL file, and restart it -- at which point a fresh copy is brought over from the primary. But that's pretty labor intensive, and I bet many users would just give up and re-clone the standby instead. A fix for this problem was already attempted in commit 515e3d84a0, but it only addressed the case for the scenario of WAL archiving, so streaming replication would still be a problem (as well as other things such as taking a filesystem-level backup while the server is down after having crashed), and it had performance scalability problems too; so it had to be reverted. This commit fixes the problem using an approach suggested by Andres Freund, whereby the initial portion(s) of the split-up WAL record are kept, and a special type of WAL record is written where the contrecord was lost, so that WAL replay in the replica knows to skip the broken parts. With this approach, we can continue to stream/archive segment files as soon as they are complete, and replay of the broken records will proceed across the crash point without a hitch. Because a new type of WAL record is added, users should be careful to upgrade standbys first, primaries later. Otherwise they risk the standby being unable to start if the primary happens to write such a record. A new TAP test that exercises this is added, but the portability of it is yet to be seen. This has been wrong since the introduction of physical replication, so backpatch all the way back. In stable branches, keep the new XLogReaderState members at the end of the struct, to avoid an ABI break. Author: Álvaro Herrera <alvherre@alvh.no-ip.org> Reviewed-by: Kyotaro Horiguchi <horikyota.ntt@gmail.com> Reviewed-by: Nathan Bossart <bossartn@amazon.com> Discussion: https://postgr.es/m/202108232252.dh7uxf6oxwcy@alvherre.pgsql		4 years ago
..
editors	Make Emacs perl-mode indent more like perltidy.	7 years ago
ifaddrs	Update copyright for 2021	5 years ago
msvc	Revert refactoring of hex code to src/common/	5 years ago
perlcheck	Prohibit map and grep in void context	5 years ago
pginclude	Add exception for unicode_east_asian_fw_table.h to headerscheck also	4 years ago
pgindent	Fix WAL replay in presence of an incomplete record	4 years ago
PerfectHash.pm	Speed up generation of Unicode hash functions.	5 years ago
RELEASE_CHANGES	Doc: further updates for RELEASE_CHANGES process notes.	5 years ago
ccsym	…
check_bison_recursion.pl	Update copyright for 2021	5 years ago
codelines	…
copyright.pl	Update copyright for 2021	5 years ago
find_badmacros	…
find_static	…
find_typedef	…
fix-old-flex-code.pl	Update copyright for 2021	5 years ago
gen_keywordlist.pl	Update copyright for 2021	5 years ago
git-external-diff	Preserve information on use of git-external-diff	8 years ago
git_changelog	Stamp HEAD as 15devel.	5 years ago
make_ctags	Improve missing-program error handling in make_ctags and make_etags.	7 years ago
make_etags	Improve missing-program error handling in make_ctags and make_etags.	7 years ago
make_mkid	…
pgtest	pgtest: run clean, build, and check stages separately	8 years ago
testint128.c	Update copyright for 2021	5 years ago
valgrind.supp	Avoid need for valgrind suppressions for pg_atomic_init_u64 on some platforms.	6 years ago
version_stamp.pl	Stamp HEAD as 15devel.	5 years ago
win32tzlist.pl	Update copyright for 2021	5 years ago