You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 58d802410a Fix assorted missing infrastructure for ON CONFLICT. ... subquery_planner() failed to apply expression preprocessing to the arbiterElems and arbiterWhere fields of an OnConflictExpr. No doubt the theory was that this wasn't necessary because we don't actually try to execute those expressions; but that's wrong, because it results in failure to match to index expressions or index predicates that are changed at all by preprocessing. Per bug #14132 from Reynold Smith. Also add pullup_replace_vars processing for onConflictWhere. Perhaps it's impossible to have a subquery reference there, but I'm not exactly convinced; and even if true today it's a failure waiting to happen. Also add some comments to other places where one or another field of OnConflictExpr is intentionally ignored, with explanation as to why it's okay to do so. Also, catalog/dependency.c failed to record any dependency on the named constraint in ON CONFLICT ON CONSTRAINT, allowing such a constraint to be dropped while rules exist that depend on it, and allowing pg_dump to dump such a rule before the constraint it refers to. The normal execution path managed to error out reasonably for a dangling constraint reference, but ruleutils.c dumped core; so in addition to fixing the omission, add a protective check in ruleutils.c, since we can't retroactively add a dependency in existing databases. Back-patch to 9.5 where this code was introduced. Report: <20160510190350.2608.48667@wrigleys.postgresql.org>		10 years ago
..
examples	Fix up .gitignore and cleanup actions in some src/test/ subdirectories.	11 years ago
isolation	Fix EvalPlanQual bug when query contains both locked and not-locked rels.	10 years ago
locale	Fix up .gitignore and cleanup actions in some src/test/ subdirectories.	11 years ago
mb	Revert "Fix broken multibyte regression tests."	10 years ago
modules	Fix phony .PHONY.	10 years ago
perl	Avoid odd portability problem in TestLib.pm's slurp_file function.	10 years ago
regress	Fix assorted missing infrastructure for ON CONFLICT.	10 years ago
ssl	Fix SSL tests	10 years ago
thread	Fix up .gitignore and cleanup actions in some src/test/ subdirectories.	11 years ago
Makefile	Fix up .gitignore and cleanup actions in some src/test/ subdirectories.	11 years ago