You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 45f9d08684 Fix race condition with unprotected use of a latch pointer variable. ... Commit 597a87ccc introduced a latch pointer variable to replace use of a long-lived shared latch in the shared WalRcvData structure. This was not well thought out, because there are now hazards of the pointer variable changing while it's being inspected by another process. This could obviously lead to a core dump in code like if (WalRcv->latch) SetLatch(WalRcv->latch); and there's a more remote risk of a torn read, if we have any platforms where reading/writing a pointer is not atomic. An actual problem would occur only if the walreceiver process exits (gracefully) while the startup process is trying to signal it, but that seems well within the realm of possibility. To fix, treat the pointer variable (not the referenced latch) as being protected by the WalRcv->mutex spinlock. There remains a race condition that we could apply SetLatch to a process latch that no longer belongs to the walreceiver, but I believe that's harmless: at worst it'd cause an extra wakeup of the next process to use that PGPROC structure. Back-patch to v10 where the faulty code was added. Discussion: https://postgr.es/m/22735.1507048202@sss.pgh.pa.us		8 years ago
..
backend	Fix race condition with unprotected use of a latch pointer variable.	8 years ago
bin	Replace most usages of ntoh[ls] and hton[sl] with pg_bswap.h.	8 years ago
common	Replace most usages of ntoh[ls] and hton[sl] with pg_bswap.h.	8 years ago
fe_utils	Provide a test for variable existence in psql	8 years ago
include	Fix race condition with unprotected use of a latch pointer variable.	8 years ago
interfaces	Replace most usages of ntoh[ls] and hton[sl] with pg_bswap.h.	8 years ago
makefiles	Always use -fPIC, not -fpic, when building shared libraries with gcc.	9 years ago
pl	Use Py_RETURN_NONE where suitable	8 years ago
port	Yet another pg_bswap typo in a windows only file.	8 years ago
template	…
test	Try to make crash restart test work on windows.	8 years ago
timezone	Sync our copy of the timezone library with IANA tzcode master.	8 years ago
tools	Support building with Visual Studio 2017	8 years ago
tutorial	Distinguish selectivity of < from <= and > from >=.	8 years ago
.gitignore	…
DEVELOPERS	…
Makefile	…
Makefile.global.in	Add PostgreSQL version to coverage output	8 years ago
Makefile.shlib	…
nls-global.mk	…