You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Tom Lane 1b47a112ac Fix GIN's shimTriConsistentFn to not corrupt its input. ... Commit 0f21db36d made an assumption that GIN triConsistentFns would not modify their input entryRes[] arrays. But in fact, the "shim" triConsistentFn that we use for opclasses that don't supply their own did exactly that, potentially leading to wrong answers from a GIN index search. Through bad luck, none of the test cases that we have for such opclasses exposed the bug. One response to this could be that the assumption of consistency check functions not modifying entryRes[] arrays is a bad one, but it still seems reasonable to me. Notably, shimTriConsistentFn is itself assuming that with respect to the underlying boolean consistentFn, so it's sure being self-centered in supposing that it gets to do so. Fortunately, it's quite simple to fix shimTriConsistentFn to restore the entry-time state of entryRes[], so let's do that instead. This issue doesn't affect any core GIN opclasses, since they all supply their own triConsistentFns. It does affect contrib modules btree_gin, hstore, and intarray. Along the way, I (tgl) noticed that shimTriConsistentFn failed to pick up on a "recheck" flag returned by its first call to the boolean consistentFn. This may be only a latent problem, since it would be unlikely for a consistentFn to set recheck for the all-false case and not any other cases. (Indeed, none of our contrib modules do that.) Nonetheless, it's formally wrong. Reported-by: Vinod Sridharan <vsridh90@gmail.com> Author: Vinod Sridharan <vsridh90@gmail.com> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAFMdLD7XzsXfi1+DpTqTgrD8XU0i2C99KuF=5VHLWjx4C1pkcg@mail.gmail.com Backpatch-through: 13		10 months ago
..
bench	Remove extraneous newlines added by perl copyright patch	5 years ago
data	Fix integer-overflow problem in intarray's g_int_decompress().	2 years ago
expected	Fix GIN's shimTriConsistentFn to not corrupt its input.	10 months ago
sql	Fix GIN's shimTriConsistentFn to not corrupt its input.	10 months ago
.gitignore	Support "make check" in contrib	15 years ago
Makefile	Remove deprecated containment operators for contrib types.	5 years ago
_int.h	Implement operator class parameters	6 years ago
_int_bool.c	Initial pgindent and pgperltidy run for v13.	6 years ago
_int_gin.c	Make the order of the header file includes consistent in contrib modules.	6 years ago
_int_gist.c	Fix integer-overflow problem in intarray's g_int_decompress().	2 years ago
_int_op.c	Clean up newlines following left parentheses	6 years ago
_int_selfuncs.c	Update copyright for 2021	5 years ago
_int_tool.c	Implement operator class parameters	6 years ago
_intbig_gist.c	Remove unnecessary pfree() in g_intbig_compress().	3 years ago
intarray--1.0--1.1.sql	Add selectivity estimation functions for intarray operators.	11 years ago
intarray--1.1--1.2.sql	Make contrib modules' installation scripts more secure.	6 years ago
intarray--1.2--1.3.sql	Implement operator class parameters	6 years ago
intarray--1.2.sql	Update extensions with GIN/GIST support for parallel query.	10 years ago
intarray--1.3--1.4.sql	Remove <@ from contrib/intarray's GiST operator classes.	6 years ago
intarray--1.4--1.5.sql	Remove deprecated containment operators for contrib types.	5 years ago
intarray.control	Remove deprecated containment operators for contrib types.	5 years ago