You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Amit Kapila f6429bd7db Fix xmin advancement during fast_forward decoding. ... During logical decoding, we advance catalog_xmin of logical too early in fast_forward mode, resulting in required catalog data being removed by vacuum. This mode is normally used to advance the slot without processing the changes, but we still can't let the slot's xmin to advance to an incorrect value. Commit f49a80c481 fixed a similar issue where the logical slot's catalog_xmin was getting advanced prematurely during non-fast-forward mode. During xl_running_xacts processing, instead of directly advancing the slot's xmin to the oldest running xid in the record, it allowed the xmin to be held back for snapshots that can be used for not-yet-replayed transactions, as those might consider older txns as running too. However, it missed the fact that the same problem can happen during fast_forward mode decoding, as we won't build a base snapshot in that mode, and the future call to get_changes from the same slot can miss seeing the required catalog changes leading to incorrect reslts. This commit allows building the base snapshot even in fast_forward mode to prevent the early advancement of xmin. Reported-by: Amit Kapila <amit.kapila16@gmail.com> Author: Zhijie Hou <houzj.fnst@fujitsu.com> Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com> Reviewed-by: shveta malik <shveta.malik@gmail.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 13 Discussion: https://postgr.es/m/CAA4eK1LqWncUOqKijiafe+Ypt1gQAQRjctKLMY953J79xDBgAg@mail.gmail.com Discussion: https://postgr.es/m/OS0PR01MB57163087F86621D44D9A72BF94BB2@OS0PR01MB5716.jpnprd01.prod.outlook.com		5 months ago
..
catalog_change_snapshot.spec	Fix catalog lookup due to wrong snapshot for subtransactions during decoding.	2 years ago
concurrent_ddl_dml.spec	…
concurrent_stream.spec	Fix 'skip-empty-xacts' option in test_decoding for streaming mode.	5 years ago
delayed_startup.spec	…
invalidation_distribution.spec	Fix typo in test file name added in commit 4909b38af0.	5 months ago
mxact.spec	Revert "Logical decoding of sequences"	3 years ago
oldest_xmin.spec	Fix xmin advancement during fast_forward decoding.	5 months ago
ondisk_startup.spec	Revert "Logical decoding of sequences"	3 years ago
skip_snapshot_restore.spec	Fix possibility of logical decoding partial transaction changes.	1 year ago
slot_creation_error.spec	Close race condition in slot_creation_error.spec.	4 years ago
snapshot_transfer.spec	Introduce xid8-based functions to replace txid_XXX.	6 years ago
subxact_without_top.spec	…
twophase_snapshot.spec	Add option to enable two_phase commits via pg_create_logical_replication_slot.	5 years ago