You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Andres Freund 500b61769f Fix bug allowing io_combine_limit > io_max_combine_combine limit ... 10f6646847 intended to limit the value of io_combine_limit to the minimum of io_combine_limit and io_max_combine_limit. To avoid issues with interdependent GUCs, it introduced io_combine_limit_guc and set io_combine_limit in assign hooks. That plan was thwarted by guc_tables.c accidentally still referencing io_combine_limit, instead of io_combine_limit_guc. That lead to the GUC machinery overriding the work done in the assign hooks, potentially leaving io_combine_limit with a too high value. The consequence of this bug was that when running with io_combine_limit > io_combine_limit_guc the AIO machinery would not have reserved large enough iovec and IO data arrays, with one IO's arrays overlapping with another IO's, leading to total confusion. To make such a problem easier to detect in the future, add assertions to pgaio_io_set_handle_data_* checking the length is smaller than io_max_combine_limit (not just PG_IOV_MAX). It'd be nice to have a few tests for this, but it's not entirely obvious how to do so portably. As remarked upon by Tom, the GUC assignment hooks really shouldn't set the underlying variable, that's the job of the GUC machinery. Change that as well. Discussion: https://postgr.es/m/c5jyqnuwrpigd35qe7xdypxsisdjrdba5iw63mhcse4mzjogxo@qdjpv22z763f		8 months ago
..
access	Fix a few duplicate words in comments	8 months ago
archive	…
backup	Use XLOG_CONTROL_FILE macro consistently for control file name.	9 months ago
bootstrap	Remove unnecessary (char *) casts [mem]	11 months ago
catalog	Change the names generated for child foreign key constraints.	8 months ago
commands	Fix bug allowing io_combine_limit > io_max_combine_combine limit	8 months ago
executor	Fix a few duplicate words in comments	8 months ago
foreign	…
jit	Allow NOT NULL constraints to be added as NOT VALID	9 months ago
lib	…
libpq	Modularize log_connections output	10 months ago
main	Use thread-safe strftime_l() instead of strftime().	9 months ago
nodes	gen_node_support.pl: improve error message for unclosed struct.	8 months ago
optimizer	Fix issue with ORDER BY / DISTINCT aggregates and FILTER	8 months ago
parser	Allow NOT NULL constraints to be added as NOT VALID	9 months ago
partitioning	Fix bug in cbc127917 to handle nested Append correctly	10 months ago
po	…
port	…
postmaster	Fix typos and grammar in the code	8 months ago
regex	Another unintentional behavior change in commit e9931bfb75.	8 months ago
replication	Fix an oversight in 3f28b2fcac.	8 months ago
rewrite	Fix incorrect handling of subquery pullup	10 months ago
snowball	Use PG_MODULE_MAGIC_EXT in our installable shared libraries.	9 months ago
statistics	Fix recently introduced typos	9 months ago
storage	Fix bug allowing io_combine_limit > io_max_combine_combine limit	8 months ago
tcop	Add function to get memory context stats for processes	9 months ago
tsearch	Clear errno before calling strtol() in spell.c.	10 months ago
utils	Fix bug allowing io_combine_limit > io_max_combine_combine limit	8 months ago
.gitignore	…
Makefile	aio: Add liburing dependency	9 months ago
common.mk	…
meson.build	…
nls.mk	Return yyparse() result not via global variable	11 months ago