You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Amit Kapila 7f13ac8123 Fix catalog lookup with the wrong snapshot during logical decoding. ... Previously, we relied on HEAP2_NEW_CID records and XACT_INVALIDATION records to know if the transaction has modified the catalog, and that information is not serialized to snapshot. Therefore, after the restart, if the logical decoding decodes only the commit record of the transaction that has actually modified a catalog, we will miss adding its XID to the snapshot. Thus, we will end up looking at catalogs with the wrong snapshot. To fix this problem, this change adds the list of transaction IDs and sub-transaction IDs, that have modified catalogs and are running during snapshot serialization, to the serialized snapshot. After restart or otherwise, when we restore from such a serialized snapshot, the corresponding list is restored in memory. Now, when decoding a COMMIT record, we check both the list and the ReorderBuffer to see if the transaction has modified catalogs. Since this adds additional information to the serialized snapshot, we cannot backpatch it. For back branches, we took another approach. We remember the last-running-xacts list of the decoded RUNNING_XACTS record after restoring the previously serialized snapshot. Then, we mark the transaction as containing catalog changes if it's in the list of initial running transactions and its commit record has XACT_XINFO_HAS_INVALS. This doesn't require any file format changes but the transaction will end up being added to the snapshot even if it has only relcache invalidations. But that won't be a problem since we use snapshot built during decoding only to read system catalogs. This commit bumps SNAPBUILD_VERSION because of a change in SnapBuild. Reported-by: Mike Oh Author: Masahiko Sawada Reviewed-by: Amit Kapila, Shi yu, Takamichi Osumi, Kyotaro Horiguchi, Bertrand Drouvot, Ahsan Hadi Backpatch-through: 10 Discussion: https://postgr.es/m/81D0D8B0-E7C4-4999-B616-1E5004DBDCD2%40amazon.com		3 years ago
..
binary.out	Message style improvements	10 years ago
catalog_change_snapshot.out	Fix catalog lookup with the wrong snapshot during logical decoding.	3 years ago
concurrent_ddl_dml.out	Improve display of query results in isolation tests.	4 years ago
concurrent_stream.out	Improve display of query results in isolation tests.	4 years ago
ddl.out	Revert "Logical decoding of sequences"	3 years ago
decoding_in_xact.out	Revert "Logical decoding of sequences"	3 years ago
decoding_into_rel.out	Revert "Logical decoding of sequences"	3 years ago
delayed_startup.out	Improve display of query results in isolation tests.	4 years ago
messages.out	Add required database and origin filtering for logical messages.	9 years ago
mxact.out	Revert "Logical decoding of sequences"	3 years ago
oldest_xmin.out	Improve display of query results in isolation tests.	4 years ago
ondisk_startup.out	Revert "Logical decoding of sequences"	3 years ago
permissions.out	Replace AclObjectKind with ObjectType	8 years ago
prepared.out	Add skip-empty-xacts option to test_decoding for use in the regression tests.	11 years ago
replorigin.out	Allow users to skip logical replication of data having origin.	3 years ago
rewrite.out	Revert "Logical decoding of sequences"	3 years ago
slot.out	Revert "Logical decoding of sequences"	3 years ago
slot_creation_error.out	Close race condition in slot_creation_error.spec.	3 years ago
snapshot_transfer.out	Improve display of query results in isolation tests.	4 years ago
spill.out	Make contrib/test_decoding regression tests safe for CZ locale.	9 years ago
stats.out	pgstat: add/extend tests for resetting various kinds of stats.	3 years ago
stream.out	Fix assertion during streaming of multi-insert toast changes.	4 years ago
subxact_without_top.out	Improve display of query results in isolation tests.	4 years ago
time.out	logical decoding: fix decoding of a commit's commit time.	9 years ago
toast.out	Revert "Logical decoding of sequences"	3 years ago
truncate.out	Revert "Logical decoding of sequences"	3 years ago
twophase.out	Use PG_TEST_TIMEOUT_DEFAULT for pg_regress suite non-elapsing timeouts.	3 years ago
twophase_snapshot.out	Improve display of query results in isolation tests.	4 years ago
twophase_stream.out	Add option to enable two_phase commits via pg_create_logical_replication_slot.	4 years ago
xact.out	Don't propagate a null subtransaction snapshot up to parent transaction.	9 years ago